diff options
author | Stan Hu <stanhu@gmail.com> | 2019-01-19 22:10:20 -0800 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2019-01-19 22:17:29 -0800 |
commit | f9e217872d26c161bc64dc7bb9456b1b22bc3259 (patch) | |
tree | 9f1dacc02ca147eced7309c5bb3ada5fe2f65974 /spec/requests/api/groups_spec.rb | |
parent | d4d4ebadfb373518013382560b1f505eb6217f13 (diff) | |
download | gitlab-ce-f9e217872d26c161bc64dc7bb9456b1b22bc3259.tar.gz |
Eliminate N+1 queries in /api/groups/:id
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/15475/diffs, a
significant amount of work went into eliminating N+1 queries in the
/api/groups/:id/projects endpoint. We can reuse the
`Entities::Project.prepare_relation` call on the projects.
In a group with 2,573 projects on GitLab.com, this change significantly
improves performance:
* 18019 SQL queries down to 21
* Time spent in DB: 70 s down to 384 ms
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/49845
Diffstat (limited to 'spec/requests/api/groups_spec.rb')
-rw-r--r-- | spec/requests/api/groups_spec.rb | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/spec/requests/api/groups_spec.rb b/spec/requests/api/groups_spec.rb index c9dfc5c4a7e..7176bc23e34 100644 --- a/spec/requests/api/groups_spec.rb +++ b/spec/requests/api/groups_spec.rb @@ -382,6 +382,20 @@ describe API::Groups do expect(response_project_ids(json_response, 'shared_projects')) .to contain_exactly(projects[:public].id, projects[:internal].id) end + + it 'avoids N+1 queries' do + get api("/groups/#{group1.id}", admin) + + control_count = ActiveRecord::QueryRecorder.new do + get api("/groups/#{group1.id}", admin) + end.count + + create(:project, namespace: group1) + + expect do + get api("/groups/#{group1.id}", admin) + end.not_to exceed_query_limit(control_count) + end end context "when authenticated as admin" do |