diff options
author | Rémy Coutable <remy@rymai.me> | 2016-09-15 18:34:57 +0200 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-09-16 17:18:26 +0200 |
commit | d8dd1c1940c929eab324951e3c302d197c5f0dda (patch) | |
tree | b691e1d71dfe7d2d50efffad82a4b9af7dfeb76c /spec/requests/api/members_spec.rb | |
parent | 7afee665b091f2afb89f0fdda90fa46d56d3e341 (diff) | |
download | gitlab-ce-d8dd1c1940c929eab324951e3c302d197c5f0dda.tar.gz |
Ensure invitees are not returned in Members API
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec/requests/api/members_spec.rb')
-rw-r--r-- | spec/requests/api/members_spec.rb | 25 |
1 files changed, 16 insertions, 9 deletions
diff --git a/spec/requests/api/members_spec.rb b/spec/requests/api/members_spec.rb index 1e365bf353a..b9cf348bbf0 100644 --- a/spec/requests/api/members_spec.rb +++ b/spec/requests/api/members_spec.rb @@ -30,20 +30,27 @@ describe API::Members, api: true do let(:route) { get api("/#{source_type.pluralize}/#{source.id}/members", stranger) } end - context 'when authenticated as a non-member' do - %i[access_requester stranger].each do |type| - context "as a #{type}" do - it 'returns 200' do - user = public_send(type) - get api("/#{source_type.pluralize}/#{source.id}/members", user) + %i[master developer access_requester stranger].each do |type| + context "when authenticated as a #{type}" do + it 'returns 200' do + user = public_send(type) + get api("/#{source_type.pluralize}/#{source.id}/members", user) - expect(response).to have_http_status(200) - expect(json_response.size).to eq(2) - end + expect(response).to have_http_status(200) + expect(json_response.size).to eq(2) end end end + it 'does not return invitees' do + invitee = create(:"#{source_type}_member", invite_token: '123', invite_email: 'test@abc.com', source: source, user: nil) + + get api("/#{source_type.pluralize}/#{source.id}/members", developer) + + expect(response).to have_http_status(200) + expect(json_response.size).to eq(2) + end + it 'finds members with query string' do get api("/#{source_type.pluralize}/#{source.id}/members", developer), query: master.username |