summaryrefslogtreecommitdiff
path: root/spec/requests/api/merge_requests_spec.rb
diff options
context:
space:
mode:
authorLin Jen-Shin <godfat@godfat.org>2017-08-09 21:41:45 +0800
committerLin Jen-Shin <godfat@godfat.org>2017-08-09 21:41:45 +0800
commit412db1874fbf2847ad9d84e9d2344d4c4d4b9fef (patch)
tree24b39366555209a0db724d9b4eb49fff4fe2e620 /spec/requests/api/merge_requests_spec.rb
parenta85eed6446fa0b4b899a71cb9a3cb5e011a41c3a (diff)
downloadgitlab-ce-412db1874fbf2847ad9d84e9d2344d4c4d4b9fef.tar.gz
Fix some tests and report the error message
Diffstat (limited to 'spec/requests/api/merge_requests_spec.rb')
-rw-r--r--spec/requests/api/merge_requests_spec.rb20
1 files changed, 16 insertions, 4 deletions
diff --git a/spec/requests/api/merge_requests_spec.rb b/spec/requests/api/merge_requests_spec.rb
index 9eda6836ded..aa52d240e39 100644
--- a/spec/requests/api/merge_requests_spec.rb
+++ b/spec/requests/api/merge_requests_spec.rb
@@ -580,15 +580,27 @@ describe API::MergeRequests do
let!(:fork_project) { create(:project, forked_from_project: project, namespace: user2.namespace, creator_id: user2.id) }
let!(:unrelated_project) { create(:project, namespace: create(:user).namespace, creator_id: user2.id) }
- before :each do |each|
- fork_project.team << [user2, :reporter]
+ before do
+ fork_project.add_reporter(user2)
+
+ Project.all.each(&method(:stub_project_repository_fetch_ref))
+ end
+
+ def stub_project_repository_fetch_ref(project)
+ allow(Project).to receive(:find_by).with(id: project.id.to_s)
+ .and_return(project)
+
+ allow(Project).to receive(:find).with(project.id)
+ .and_return(project)
+
+ allow(project.repository).to receive(:fetch_ref)
end
it "returns merge_request" do
post api("/projects/#{fork_project.id}/merge_requests", user2),
title: 'Test merge_request', source_branch: "feature_conflict", target_branch: "master",
author: user2, target_project_id: project.id, description: 'Test description for Test merge_request'
- expect(response).to have_http_status(201)
+ expect(response).to have_gitlab_http_status(201)
expect(json_response['title']).to eq('Test merge_request')
expect(json_response['description']).to eq('Test description for Test merge_request')
end
@@ -599,7 +611,7 @@ describe API::MergeRequests do
expect(fork_project.forked_from_project).to eq(project)
post api("/projects/#{fork_project.id}/merge_requests", user2),
title: 'Test merge_request', source_branch: "master", target_branch: "master", author: user2, target_project_id: project.id
- expect(response).to have_http_status(201)
+ expect(response).to have_gitlab_http_status(201)
expect(json_response['title']).to eq('Test merge_request')
end