diff options
author | Robert Schilling <rschilling@student.tugraz.at> | 2016-04-06 19:04:17 +0200 |
---|---|---|
committer | Robert Schilling <rschilling@student.tugraz.at> | 2016-04-12 14:24:05 +0200 |
commit | 9aefaa41ab1442f81ffc15ad9a8279bd1e92c91a (patch) | |
tree | 581326d413b1d83d237186c6a123da50787d3104 /spec/requests/api/notes_spec.rb | |
parent | ba21c00f01bf4274d0e4cc3892293fc1e581b260 (diff) | |
download | gitlab-ce-9aefaa41ab1442f81ffc15ad9a8279bd1e92c91a.tar.gz |
Fix code review issues
Diffstat (limited to 'spec/requests/api/notes_spec.rb')
-rw-r--r-- | spec/requests/api/notes_spec.rb | 20 |
1 files changed, 19 insertions, 1 deletions
diff --git a/spec/requests/api/notes_spec.rb b/spec/requests/api/notes_spec.rb index 23d3c63bc1c..b35e67b5bd3 100644 --- a/spec/requests/api/notes_spec.rb +++ b/spec/requests/api/notes_spec.rb @@ -241,16 +241,22 @@ describe API::API, api: true do end end - describe ':id/#{noteables_str}/:#{noteable_id_str}/notes/:note_id' do + describe 'DELETE /projects/:id/noteable/:noteable_id/notes/:note_id' do context 'when noteable is an Issue' do it 'should delete a note' do delete api("/projects/#{project.id}/issues/#{issue.id}/"\ "notes/#{issue_note.id}", user) + expect(response.status).to eq(200) + # Check if note is really deleted + delete api("/projects/#{project.id}/issues/#{issue.id}/"\ + "notes/#{issue_note.id}", user) + expect(response.status).to eq(404) end it 'should return a 404 error when note id not found' do delete api("/projects/#{project.id}/issues/#{issue.id}/notes/123", user) + expect(response.status).to eq(404) end end @@ -259,12 +265,18 @@ describe API::API, api: true do it 'should delete a note' do delete api("/projects/#{project.id}/snippets/#{snippet.id}/"\ "notes/#{snippet_note.id}", user) + expect(response.status).to eq(200) + # Check if note is really deleted + delete api("/projects/#{project.id}/snippets/#{snippet.id}/"\ + "notes/#{snippet_note.id}", user) + expect(response.status).to eq(404) end it 'should return a 404 error when note id not found' do delete api("/projects/#{project.id}/snippets/#{snippet.id}/"\ "notes/123", user) + expect(response.status).to eq(404) end end @@ -273,12 +285,18 @@ describe API::API, api: true do it 'should delete a note' do delete api("/projects/#{project.id}/merge_requests/"\ "#{merge_request.id}/notes/#{merge_request_note.id}", user) + expect(response.status).to eq(200) + # Check if note is really deleted + delete api("/projects/#{project.id}/merge_requests/"\ + "#{merge_request.id}/notes/#{merge_request_note.id}", user) + expect(response.status).to eq(404) end it 'should return a 404 error when note id not found' do delete api("/projects/#{project.id}/merge_requests/"\ "#{merge_request.id}/notes/123", user) + expect(response.status).to eq(404) end end |