summaryrefslogtreecommitdiff
path: root/spec/requests/api/project_hooks_spec.rb
diff options
context:
space:
mode:
authorRobert Schilling <rschilling@student.tugraz.at>2017-02-20 19:18:12 +0100
committerRobert Schilling <rschilling@student.tugraz.at>2017-02-28 08:32:38 +0100
commit86c58687b22f788ad7c821af55abece2f9d89d50 (patch)
treeeb07659dee80d897170fc4965a124251a22a913a /spec/requests/api/project_hooks_spec.rb
parent7733f285aca97d444382a59eda0ea3e303539c26 (diff)
downloadgitlab-ce-86c58687b22f788ad7c821af55abece2f9d89d50.tar.gz
Return 204 for delete endpoints
Diffstat (limited to 'spec/requests/api/project_hooks_spec.rb')
-rw-r--r--spec/requests/api/project_hooks_spec.rb8
1 files changed, 2 insertions, 6 deletions
diff --git a/spec/requests/api/project_hooks_spec.rb b/spec/requests/api/project_hooks_spec.rb
index 20c76bd2c05..f286568547d 100644
--- a/spec/requests/api/project_hooks_spec.rb
+++ b/spec/requests/api/project_hooks_spec.rb
@@ -183,13 +183,9 @@ describe API::ProjectHooks, 'ProjectHooks', api: true do
it "deletes hook from project" do
expect do
delete api("/projects/#{project.id}/hooks/#{hook.id}", user)
- end.to change {project.hooks.count}.by(-1)
- expect(response).to have_http_status(200)
- end
- it "returns success when deleting hook" do
- delete api("/projects/#{project.id}/hooks/#{hook.id}", user)
- expect(response).to have_http_status(200)
+ expect(response).to have_http_status(204)
+ end.to change {project.hooks.count}.by(-1)
end
it "returns a 404 error when deleting non existent hook" do