summaryrefslogtreecommitdiff
path: root/spec/requests/api/projects_spec.rb
diff options
context:
space:
mode:
authorToon Claes <toon@gitlab.com>2017-03-09 16:39:09 +0100
committerToon Claes <toon@gitlab.com>2017-03-10 10:03:03 +0100
commitc92808ed323d70c6af00cd19fb5e4ed35ce9957d (patch)
tree4992cd77091121d4e4a1546d880634abc408a0d0 /spec/requests/api/projects_spec.rb
parent7a7f487775d4ed3de5698064b90af6da6488a59b (diff)
downloadgitlab-ce-c92808ed323d70c6af00cd19fb5e4ed35ce9957d.tar.gz
Fix for creating a project through API when import_url is niltc-fix-project-create-500
The API was returning 500 when `nil` is passed for the `import_url`. In fact, it was `Gitlab::UrlSanitizer.valid?` which was throwing a `NoMethodError` when `nil` value was passed.
Diffstat (limited to 'spec/requests/api/projects_spec.rb')
-rw-r--r--spec/requests/api/projects_spec.rb8
1 files changed, 8 insertions, 0 deletions
diff --git a/spec/requests/api/projects_spec.rb b/spec/requests/api/projects_spec.rb
index 77f79cd5bc7..b4b23617498 100644
--- a/spec/requests/api/projects_spec.rb
+++ b/spec/requests/api/projects_spec.rb
@@ -424,6 +424,14 @@ describe API::Projects, api: true do
expect(json_response['only_allow_merge_if_all_discussions_are_resolved']).to be_truthy
end
+ it 'ignores import_url when it is nil' do
+ project = attributes_for(:project, { import_url: nil })
+
+ post api('/projects', user), project
+
+ expect(response).to have_http_status(201)
+ end
+
context 'when a visibility level is restricted' do
let(:project_param) { attributes_for(:project, visibility: 'public') }