diff options
author | Rémy Coutable <remy@rymai.me> | 2018-04-16 12:30:40 +0200 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-04-17 15:20:07 +0200 |
commit | 422aa5a62d704f5656d15dd79677d4393f0668a2 (patch) | |
tree | 209ca0c00b1acbbd0d3aa98778aa35a697ce9e80 /spec/requests/api/repositories_spec.rb | |
parent | 4ed152e4ba7efede082a9c8884fd94f0a113e398 (diff) | |
download | gitlab-ce-422aa5a62d704f5656d15dd79677d4393f0668a2.tar.gz |
[API] Fix URLs in the 'Link' header for 'GET /projects/:id/repository/contributors' when no value is passed for 'order_by' or 'sort'
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'spec/requests/api/repositories_spec.rb')
-rw-r--r-- | spec/requests/api/repositories_spec.rb | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/spec/requests/api/repositories_spec.rb b/spec/requests/api/repositories_spec.rb index 741800ff61d..9e6d69e3874 100644 --- a/spec/requests/api/repositories_spec.rb +++ b/spec/requests/api/repositories_spec.rb @@ -427,5 +427,20 @@ describe API::Repositories do let(:request) { get api(route, guest) } end end + + # Regression: https://gitlab.com/gitlab-org/gitlab-ce/issues/45363 + describe 'Links header contains working URLs when no `order_by` nor `sort` is given' do + let(:project) { create(:project, :public, :repository) } + let(:current_user) { nil } + + it 'returns `Link` header that includes URLs with default value for `order_by` & `sort`' do + get api(route, current_user) + + first_link_url = response.headers['Link'].split(';').first + + expect(first_link_url).to include('order_by=commits') + expect(first_link_url).to include('sort=asc') + end + end end end |