summaryrefslogtreecommitdiff
path: root/spec/requests/api
diff options
context:
space:
mode:
authorRobert Speicher <robert@gitlab.com>2016-11-25 04:16:39 +0000
committerRobert Speicher <robert@gitlab.com>2016-11-25 04:16:39 +0000
commit40fa5604f38409f12d709c425286a6047d2c8e06 (patch)
treebd4ff5e4258d3642c8d37d73da1bb543f3e40ad8 /spec/requests/api
parent5522b9dc0e488a4561e7791c8d85e39615da2901 (diff)
parent71ad3d294ec6ddfb36346e19e6b50ec5eb8d4ef2 (diff)
downloadgitlab-ce-40fa5604f38409f12d709c425286a6047d2c8e06.tar.gz
Merge branch 'fix/invalid-storage-cleanup-affecting-test-suite' into 'master'
Make test suite deterministic when storage is involved ## What does this MR do? This MR fixes our RSpec test harness because one test example could affect subsequent examples if objects created with `let` had associated files stored in `tmp/tests`. We store files using CarrierWave, but we also have some custom storage rules for CI builds. Some time ago we introduced MR that purged CarrierWave uploads after each run of entire test suite https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3435, but this is not enough, as we should isolate each test example to be able to rely on deterministic test suite. Not cleaning uploads between each test example run, makes it impossible to know if preconditions are correct before test example starts to run, therefore it makes test examples, that use storage, unreliable. This MR is an attempt to improve that. ## What are the relevant issue numbers? Closes #24808 See merge request !7695
Diffstat (limited to 'spec/requests/api')
0 files changed, 0 insertions, 0 deletions