summaryrefslogtreecommitdiff
path: root/spec/requests
diff options
context:
space:
mode:
authorTomasz Maczukin <tomasz@maczukin.pl>2016-02-17 15:27:28 +0100
committerTomasz Maczukin <tomasz@maczukin.pl>2016-02-19 13:18:48 +0100
commitd38322b8952292951fa008cb3300c73933f64fb4 (patch)
treed94cffd313d2a4df5e4005ee5cd847d85f1f703a /spec/requests
parent957c4de9b1e9d2de79f8f35f63e0143096ccd040 (diff)
downloadgitlab-ce-d38322b8952292951fa008cb3300c73933f64fb4.tar.gz
Change `.map{...}.inject{...}` to `any?{...}` for searching shared runners
Diffstat (limited to 'spec/requests')
-rw-r--r--spec/requests/api/runners_spec.rb10
1 files changed, 5 insertions, 5 deletions
diff --git a/spec/requests/api/runners_spec.rb b/spec/requests/api/runners_spec.rb
index eb4327d885f..6ad62f7d6fc 100644
--- a/spec/requests/api/runners_spec.rb
+++ b/spec/requests/api/runners_spec.rb
@@ -37,7 +37,7 @@ describe API::API, api: true do
context 'authorized user' do
it 'should return user available runners' do
get api('/runners', user)
- shared = json_response.map{ |r| r['is_shared'] }.inject{ |sum, shr| sum || shr}
+ shared = json_response.any?{ |r| r['is_shared'] }
expect(response.status).to eq(200)
expect(json_response).to be_an Array
@@ -46,7 +46,7 @@ describe API::API, api: true do
it 'should filter runners by scope' do
get api('/runners?scope=active', user)
- shared = json_response.map{ |r| r['is_shared'] }.inject{ |sum, shr| sum || shr}
+ shared = json_response.any?{ |r| r['is_shared'] }
expect(response.status).to eq(200)
expect(json_response).to be_an Array
@@ -73,7 +73,7 @@ describe API::API, api: true do
context 'with admin privileges' do
it 'should return all runners' do
get api('/runners/all', admin)
- shared = json_response.map{ |r| r['is_shared'] }.inject{ |sum, shr| sum || shr}
+ shared = json_response.any?{ |r| r['is_shared'] }
expect(response.status).to eq(200)
expect(json_response).to be_an Array
@@ -91,7 +91,7 @@ describe API::API, api: true do
it 'should filter runners by scope' do
get api('/runners/all?scope=specific', admin)
- shared = json_response.map{ |r| r['is_shared'] }.inject{ |sum, shr| sum || shr}
+ shared = json_response.any?{ |r| r['is_shared'] }
expect(response.status).to eq(200)
expect(json_response).to be_an Array
@@ -326,7 +326,7 @@ describe API::API, api: true do
context 'authorized user with master privileges' do
it "should return project's runners" do
get api("/projects/#{project.id}/runners", user)
- shared = json_response.map{ |r| r['is_shared'] }.inject{ |sum, shr| sum || shr}
+ shared = json_response.any?{ |r| r['is_shared'] }
expect(response.status).to eq(200)
expect(json_response).to be_an Array