diff options
author | GitLab Release Tools Bot <robert+release-tools@gitlab.com> | 2019-04-02 07:48:28 +0000 |
---|---|---|
committer | GitLab Release Tools Bot <robert+release-tools@gitlab.com> | 2019-04-02 07:48:28 +0000 |
commit | b122be5ed55e3898196fb21e47fff40eb7dd6e0c (patch) | |
tree | 709d2763de4f693086b1f0cbe8848df3a8ed5509 /spec/requests | |
parent | 02dcecdb5f51f6988ede356d0d245d6cd7745520 (diff) | |
parent | 732f892db308863f2a2db736949c94ae9d613678 (diff) | |
download | gitlab-ce-b122be5ed55e3898196fb21e47fff40eb7dd6e0c.tar.gz |
Merge branch 'security-id-potential-denial-languages' into 'master'
Return cached languages if they've been detected before
See merge request gitlab/gitlabhq!2998
Diffstat (limited to 'spec/requests')
-rw-r--r-- | spec/requests/api/projects_spec.rb | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/spec/requests/api/projects_spec.rb b/spec/requests/api/projects_spec.rb index 60d9d7fed13..fdbb78b8829 100644 --- a/spec/requests/api/projects_spec.rb +++ b/spec/requests/api/projects_spec.rb @@ -13,12 +13,18 @@ shared_examples 'languages and percentages JSON response' do ) end - it 'returns expected language values' do - get api("/projects/#{project.id}/languages", user) + context "when the languages haven't been detected yet" do + it 'returns expected language values' do + get api("/projects/#{project.id}/languages", user) + + expect(response).to have_gitlab_http_status(:ok) + expect(json_response).to eq({}) - expect(response).to have_gitlab_http_status(:ok) - expect(json_response).to eq(expected_languages) - expect(json_response.count).to be > 1 + get api("/projects/#{project.id}/languages", user) + + expect(response).to have_gitlab_http_status(:ok) + expect(JSON.parse(response.body)).to eq(expected_languages) + end end context 'when the languages were detected before' do |