summaryrefslogtreecommitdiff
path: root/spec/requests
diff options
context:
space:
mode:
authorJan Provaznik <jprovaznik@gitlab.com>2019-09-17 14:38:09 +0200
committerJan Provaznik <jprovaznik@gitlab.com>2019-09-24 16:22:17 +0200
commitbc22ef7b6e472eac085498e5ab82239e53498912 (patch)
treed40bb93ab01b7f093b1ecbe7f2180e80c2915ac1 /spec/requests
parent3440d0f6100fc25e052e19801361aa99636d82c1 (diff)
downloadgitlab-ce-bc22ef7b6e472eac085498e5ab82239e53498912.tar.gz
Filter not accessible label events
Label events may use cross-project or cross-group references, if the projects are not accessible by user, we don't show these label events.
Diffstat (limited to 'spec/requests')
-rw-r--r--spec/requests/api/resource_label_events_spec.rb11
1 files changed, 3 insertions, 8 deletions
diff --git a/spec/requests/api/resource_label_events_spec.rb b/spec/requests/api/resource_label_events_spec.rb
index 25bea627b0c..8bac378787c 100644
--- a/spec/requests/api/resource_label_events_spec.rb
+++ b/spec/requests/api/resource_label_events_spec.rb
@@ -5,28 +5,23 @@ require 'spec_helper'
describe API::ResourceLabelEvents do
set(:user) { create(:user) }
set(:project) { create(:project, :public, namespace: user.namespace) }
+ set(:label) { create(:label, project: project) }
before do
project.add_developer(user)
end
context 'when eventable is an Issue' do
- let(:issue) { create(:issue, project: project, author: user) }
-
it_behaves_like 'resource_label_events API', 'projects', 'issues', 'iid' do
let(:parent) { project }
- let(:eventable) { issue }
- let!(:event) { create(:resource_label_event, issue: issue) }
+ let(:eventable) { create(:issue, project: project, author: user) }
end
end
context 'when eventable is a Merge Request' do
- let(:merge_request) { create(:merge_request, source_project: project, target_project: project, author: user) }
-
it_behaves_like 'resource_label_events API', 'projects', 'merge_requests', 'iid' do
let(:parent) { project }
- let(:eventable) { merge_request }
- let!(:event) { create(:resource_label_event, merge_request: merge_request) }
+ let(:eventable) { create(:merge_request, source_project: project, target_project: project, author: user) }
end
end
end