summaryrefslogtreecommitdiff
path: root/spec/routing
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2017-11-08 09:28:50 +0000
committerDouwe Maan <douwe@gitlab.com>2017-11-08 09:28:50 +0000
commitb579cc7620dad1d406e974cce2d9ad5a4ce58a57 (patch)
treef377a0458e3d57b7fe76e3a35a33430da9c9ff45 /spec/routing
parentf2f58a60b76acd479e37bdbc9246ec9f9b2bea82 (diff)
parent4dea7944c46287707b6b65ca10e0af0b69a57a21 (diff)
downloadgitlab-ce-b579cc7620dad1d406e974cce2d9ad5a4ce58a57.tar.gz
Merge branch 'feature-change-signout-route' into 'master'
Change Sign Out route from a DELETE to a GET Closes #39708 See merge request gitlab-org/gitlab-ce!15231
Diffstat (limited to 'spec/routing')
-rw-r--r--spec/routing/routing_spec.rb6
1 files changed, 4 insertions, 2 deletions
diff --git a/spec/routing/routing_spec.rb b/spec/routing/routing_spec.rb
index 32aa6e5ad52..91aefa84d0e 100644
--- a/spec/routing/routing_spec.rb
+++ b/spec/routing/routing_spec.rb
@@ -257,8 +257,10 @@ describe "Authentication", "routing" do
expect(post("/users/sign_in")).to route_to('sessions#create')
end
- it "DELETE /users/sign_out" do
- expect(delete("/users/sign_out")).to route_to('sessions#destroy')
+ # sign_out with GET instead of DELETE facilitates ad-hoc single-sign-out processes
+ # (https://gitlab.com/gitlab-org/gitlab-ce/issues/39708)
+ it "GET /users/sign_out" do
+ expect(get("/users/sign_out")).to route_to('sessions#destroy')
end
it "POST /users/password" do