diff options
author | Toon Claes <toon@gitlab.com> | 2018-11-22 21:13:36 +0100 |
---|---|---|
committer | Toon Claes <toon@gitlab.com> | 2018-11-27 11:40:38 +0100 |
commit | 54b639195ddb2d11b5a5e8208d5f94df365041db (patch) | |
tree | df4502706a4e7af55c0d8f27f3e8ddb65f37e957 /spec/rubocop | |
parent | b18556f0adbd05151c026146a7929ac830ca4bc6 (diff) | |
download | gitlab-ce-54b639195ddb2d11b5a5e8208d5f94df365041db.tar.gz |
Make add_reference cop accept a hash for :index
It might happen you want to make the reference column have a unique
value, or you want to create partial indexes. So instead of only
accepting a `true` value, also accept a hash of options.
Diffstat (limited to 'spec/rubocop')
-rw-r--r-- | spec/rubocop/cop/migration/add_reference_spec.rb | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/spec/rubocop/cop/migration/add_reference_spec.rb b/spec/rubocop/cop/migration/add_reference_spec.rb index 8f795bb561e..c348fc0efac 100644 --- a/spec/rubocop/cop/migration/add_reference_spec.rb +++ b/spec/rubocop/cop/migration/add_reference_spec.rb @@ -29,7 +29,7 @@ describe RuboCop::Cop::Migration::AddReference do expect_offense(<<~RUBY) call do add_reference(:projects, :users) - ^^^^^^^^^^^^^ `add_reference` requires `index: true` + ^^^^^^^^^^^^^ `add_reference` requires `index: true` or `index: { options... }` end RUBY end @@ -38,7 +38,7 @@ describe RuboCop::Cop::Migration::AddReference do expect_offense(<<~RUBY) def up add_reference(:projects, :users, index: false) - ^^^^^^^^^^^^^ `add_reference` requires `index: true` + ^^^^^^^^^^^^^ `add_reference` requires `index: true` or `index: { options... }` end RUBY end @@ -50,5 +50,13 @@ describe RuboCop::Cop::Migration::AddReference do end RUBY end + + it 'does not register an offense when the index is unique' do + expect_no_offenses(<<~RUBY) + def up + add_reference(:projects, :users, index: { unique: true } ) + end + RUBY + end end end |