Applies rule only when extending ActiveSupport::Concern

1 files changed, 22 insertions, 1 deletions

diff --git a/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb b/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb
index 64b1f1b948d..527c236eecf 100644
--- a/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb
+++ b/spec/rubocop/cop/prefer_class_methods_over_module_spec.rb
@@ -10,9 +10,11 @@ describe RuboCop::Cop::PreferClassMethodsOverModule do
 
   subject(:cop) { described_class.new }
 
-  it 'flags violation when using ClassMethods' do
+  it 'flags violation when using module ClassMethods' do
     expect_offense(<<~RUBY)
       module Foo
+        extend ActiveSupport::Concern
+
         module ClassMethods
         ^^^^^^^^^^^^^^^^^^^ Do not use module ClassMethods, use class_methods block instead.
           def a_class_method
@@ -25,6 +27,8 @@ describe RuboCop::Cop::PreferClassMethodsOverModule do
   it "doesn't flag violation when using class_methods" do
     expect_no_offenses(<<~RUBY)
       module Foo
+        extend ActiveSupport::Concern
+
         class_methods do
           def a_class_method
           end
@@ -33,9 +37,22 @@ describe RuboCop::Cop::PreferClassMethodsOverModule do
     RUBY
   end
 
+  it "doesn't flag violation when module is not extending ActiveSupport::Concern" do
+    expect_no_offenses(<<~RUBY)
+      module Foo
+        module ClassMethods
+          def a_class_method
+          end
+        end
+      end
+    RUBY
+  end
+
   it "doesn't flag violation when not using either class_methods or ClassMethods" do
     expect_no_offenses(<<~RUBY)
       module Foo
+        extend ActiveSupport::Concern
+
         def a_method
         end
       end
@@ -45,6 +62,8 @@ describe RuboCop::Cop::PreferClassMethodsOverModule do
   it 'autocorrects ClassMethods into class_methods' do
     source = <<~RUBY
       module Foo
+        extend ActiveSupport::Concern
+
         module ClassMethods
           def a_class_method
           end
@@ -55,6 +74,8 @@ describe RuboCop::Cop::PreferClassMethodsOverModule do
 
     expected_source = <<~RUBY
       module Foo
+        extend ActiveSupport::Concern
+
         class_methods do
           def a_class_method
           end