summaryrefslogtreecommitdiff
path: root/spec/rubocop
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2019-11-20 21:06:38 +0000
committerGitLab Bot <gitlab-bot@gitlab.com>2019-11-20 21:06:38 +0000
commit2477ab5553eabc6c4579cb23aba620ffc8cba228 (patch)
tree72d34d8135c6318130e9697b900507dace9cb035 /spec/rubocop
parentfdffdcf1abaa2cab903f1d32610eb562cdf53906 (diff)
downloadgitlab-ce-2477ab5553eabc6c4579cb23aba620ffc8cba228.tar.gz
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/rubocop')
-rw-r--r--spec/rubocop/cop/migration/add_index_spec.rb39
1 files changed, 39 insertions, 0 deletions
diff --git a/spec/rubocop/cop/migration/add_index_spec.rb b/spec/rubocop/cop/migration/add_index_spec.rb
new file mode 100644
index 00000000000..0c3f87e5bf8
--- /dev/null
+++ b/spec/rubocop/cop/migration/add_index_spec.rb
@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+require 'rubocop'
+require 'rubocop/rspec/support'
+
+require_relative '../../../../rubocop/cop/migration/add_index'
+
+describe RuboCop::Cop::Migration::AddIndex do
+ include CopHelper
+
+ subject(:cop) { described_class.new }
+
+ context 'in migration' do
+ before do
+ allow(cop).to receive(:in_migration?).and_return(true)
+ end
+
+ it 'registers an offense when add_index is used' do
+ expect_offense(<<~PATTERN.strip_indent)
+ def change
+ add_index :table, :column
+ ^^^^^^^^^ `add_index` requires downtime, use `add_concurrent_index` instead
+ end
+ PATTERN
+ end
+ end
+
+ context 'outside of migration' do
+ it 'registers no offense' do
+ expect_no_offenses(<<~PATTERN.strip_indent)
+ def change
+ add_index :table, :column
+ end
+ PATTERN
+ end
+ end
+end