diff options
author | Robert Speicher <rspeicher@gmail.com> | 2017-04-24 12:48:35 -0500 |
---|---|---|
committer | Robert Speicher <rspeicher@gmail.com> | 2017-04-28 15:55:55 -0500 |
commit | b9fa17d87b534e588d80bb029c7f8cf9f9ff0c45 (patch) | |
tree | 11af18e9ec7f21e687c31b5f3fca414cd19b6892 /spec/rubocop | |
parent | 9c27c90b4a8a9ea179af9588a7dbd2037829905f (diff) | |
download | gitlab-ce-b9fa17d87b534e588d80bb029c7f8cf9f9ff0c45.tar.gz |
Add AddColumnWithDefaultToLargeTable cop
Diffstat (limited to 'spec/rubocop')
-rw-r--r-- | spec/rubocop/cop/migration/add_column_with_default_to_large_table_spec.rb | 44 |
1 files changed, 44 insertions, 0 deletions
diff --git a/spec/rubocop/cop/migration/add_column_with_default_to_large_table_spec.rb b/spec/rubocop/cop/migration/add_column_with_default_to_large_table_spec.rb new file mode 100644 index 00000000000..07cb3fc4a2e --- /dev/null +++ b/spec/rubocop/cop/migration/add_column_with_default_to_large_table_spec.rb @@ -0,0 +1,44 @@ +require 'spec_helper' + +require 'rubocop' +require 'rubocop/rspec/support' + +require_relative '../../../../rubocop/cop/migration/add_column_with_default_to_large_table' + +describe RuboCop::Cop::Migration::AddColumnWithDefaultToLargeTable do + include CopHelper + + subject(:cop) { described_class.new } + + context 'in migration' do + before do + allow(cop).to receive(:in_migration?).and_return(true) + end + + described_class::LARGE_TABLES.each do |table| + it "registers an offense for the #{table} table" do + inspect_source(cop, "add_column_with_default :#{table}, :column, default: true") + + aggregate_failures do + expect(cop.offenses.size).to eq(1) + expect(cop.offenses.map(&:line)).to eq([1]) + end + end + end + + it 'registers no offense for non-blacklisted tables' do + inspect_source(cop, "add_column_with_default :table, :column, default: true") + + expect(cop.offenses).to be_empty + end + end + + context 'outside of migration' do + it 'registers no offense' do + table = described_class::LARGE_TABLES.sample + inspect_source(cop, "add_column_with_default :#{table}, :column, default: true") + + expect(cop.offenses).to be_empty + end + end +end |