diff options
author | José Iván Vargas López <jvargas@gitlab.com> | 2018-08-28 21:26:54 +0000 |
---|---|---|
committer | José Iván Vargas López <jvargas@gitlab.com> | 2018-08-28 21:26:54 +0000 |
commit | f2a170732993c1df510fd64a95f086d5592c658b (patch) | |
tree | c35aa0de0295a29912b3d4211a7dc003d552b1d7 /spec/serializers | |
parent | b1992a92f11056157bc854be538074482b72ee20 (diff) | |
parent | 5e8f11e5fdb792f17d86cf9321537c5c56801a17 (diff) | |
download | gitlab-ce-f2a170732993c1df510fd64a95f086d5592c658b.tar.gz |
Merge branch 'security-2694-pipeline' into 'master'
[master] Removes `<br>` sent from backend on tooltips in jobs
See merge request gitlab/gitlabhq!2455
Diffstat (limited to 'spec/serializers')
-rw-r--r-- | spec/serializers/build_serializer_spec.rb | 2 | ||||
-rw-r--r-- | spec/serializers/job_entity_spec.rb | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/spec/serializers/build_serializer_spec.rb b/spec/serializers/build_serializer_spec.rb index 52459cd369d..302ef147eb2 100644 --- a/spec/serializers/build_serializer_spec.rb +++ b/spec/serializers/build_serializer_spec.rb @@ -37,7 +37,7 @@ describe BuildSerializer do it 'serializes only status' do expect(subject[:text]).to eq(status.text) expect(subject[:label]).to eq('failed') - expect(subject[:tooltip]).to eq('failed <br> (unknown failure)') + expect(subject[:tooltip]).to eq('failed - (unknown failure)') expect(subject[:icon]).to eq(status.icon) expect(subject[:favicon]).to match_asset_path("/assets/ci_favicons/#{status.favicon}.png") end diff --git a/spec/serializers/job_entity_spec.rb b/spec/serializers/job_entity_spec.rb index a5581a34517..8e1ca3f308d 100644 --- a/spec/serializers/job_entity_spec.rb +++ b/spec/serializers/job_entity_spec.rb @@ -142,7 +142,7 @@ describe JobEntity do end it 'should indicate the failure reason on tooltip' do - expect(subject[:status][:tooltip]).to eq('failed <br> (API failure)') + expect(subject[:status][:tooltip]).to eq('failed - (API failure)') end it 'should include a callout message with a verbose output' do @@ -166,7 +166,7 @@ describe JobEntity do end it 'should indicate the failure reason on tooltip' do - expect(subject[:status][:tooltip]).to eq('failed <br> (API failure) (allowed to fail)') + expect(subject[:status][:tooltip]).to eq('failed - (API failure) (allowed to fail)') end it 'should include a callout message with a verbose output' do |