Require `needs:` to be presentrequire-needs-to-be-present

This changes the `needs:` logic to require
that all jobs to be present. Instead of skipping
do fail the pipeline creation if `needs:` dependency
is not found.

1 files changed, 2 insertions, 1 deletions

diff --git a/spec/services/ci/create_pipeline_service_spec.rb b/spec/services/ci/create_pipeline_service_spec.rb
index 7e2f311a065..deb68899309 100644
--- a/spec/services/ci/create_pipeline_service_spec.rb
+++ b/spec/services/ci/create_pipeline_service_spec.rb
@@ -1113,7 +1113,7 @@ describe Ci::CreatePipelineService do
           test_a: {
             stage: "test",
             script: "ls",
-            only: %w[master feature tags],
+            only: %w[master feature],
             needs: %w[build_a]
           },
           deploy: {
@@ -1143,6 +1143,7 @@ describe Ci::CreatePipelineService do
         it 'does not create a pipeline as test_a depends on build_a' do
           expect(pipeline).not_to be_persisted
           expect(pipeline.builds).to be_empty
+          expect(pipeline.errors[:base]).to contain_exactly("test_a: needs 'build_a'")
         end
       end