summaryrefslogtreecommitdiff
path: root/spec/services/create_commit_builds_service_spec.rb
diff options
context:
space:
mode:
authorRémy Coutable <remy@rymai.me>2016-06-15 17:35:37 +0000
committerRémy Coutable <remy@rymai.me>2016-06-15 17:35:37 +0000
commit32a5ff70d771e7bff4e5c7b42fe95a966fa47a96 (patch)
tree61020f184356de6f2f62fbd32d939299ee46220f /spec/services/create_commit_builds_service_spec.rb
parentaf493ccf3658c9f8b1266a880eb1798fe30cb324 (diff)
parent8a9164bf04fe20bfee9ea7923c655f4600e88c7f (diff)
downloadgitlab-ce-32a5ff70d771e7bff4e5c7b42fe95a966fa47a96.tar.gz
Merge branch 'project-services-inverse-of' into 'master'
Set inverse_of for Project/Services relation ## What does this MR do? This MR adds the `inverse_of:` option to two associations to reduce the number of queries when running code such as ` project.gitlab_issue_tracker_service.project`. ## Are there points in the code the reviewer needs to double check? No. ## Why was this MR needed? In !4410 it was revealed code such as the above is used and would run SQL queries when the root object (usually a Project) was already present. By using `inverse_of` Rails can just re-use those Project instances. ## What are the relevant issue numbers? None. ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [x] ~~[Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)~~ - [x] ~~API support added~~ - [x] Tests - [x] ~~Added for this feature/bug~~ - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4674
Diffstat (limited to 'spec/services/create_commit_builds_service_spec.rb')
0 files changed, 0 insertions, 0 deletions