diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-07-12 10:47:36 +0530 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-07-13 14:18:05 +0530 |
| commit | bb81f2afc1d82d6e88d7039025c8a8be0794aac6 (patch) | |
| tree | e016e94d8e0d709ca4d614a0ecae81b4bfe48700 /spec/services/git_push_service_spec.rb | |
| parent | ea9e8f4609f46f9c5713a8346f91dc19d310c2e1 (diff) | |
| download | gitlab-ce-bb81f2afc1d82d6e88d7039025c8a8be0794aac6.tar.gz | |
Implement last round of review comments from !4892.18193-developers-can-merge
1. Fix typos, minor styling errors.
2. Use single quotes rather than double quotes in `user_access_spec`.
3. Test formatting.
Diffstat (limited to 'spec/services/git_push_service_spec.rb')
| -rw-r--r-- | spec/services/git_push_service_spec.rb | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/spec/services/git_push_service_spec.rb b/spec/services/git_push_service_spec.rb index 0f30a84a2cf..47c0580e0f0 100644 --- a/spec/services/git_push_service_spec.rb +++ b/spec/services/git_push_service_spec.rb @@ -243,7 +243,8 @@ describe GitPushService, services: true do expect(project).to receive(:execute_hooks) expect(project.default_branch).to eq("master") expect(project.protected_branches).to receive(:create).with({ name: "master", developers_can_push: true, developers_can_merge: false }) - execute_service(project, user, @blankrev, 'newrev', 'refs/heads/master' ) + + execute_service(project, user, @blankrev, 'newrev', 'refs/heads/master') end it "when pushing a branch for the first time with default branch protection set to 'developers can merge'" do |