diff options
| author | Pierre de La Morinerie <pierre@capitainetrain.com> | 2014-02-21 19:39:09 +0100 |
|---|---|---|
| committer | Pierre de La Morinerie <pierre@capitainetrain.com> | 2014-06-10 17:09:15 +0200 |
| commit | 466b768bb34730ee6a24d950333c232009c34bbd (patch) | |
| tree | 7ee2e0263b60e495c4c5013376d3564a92811f22 /spec/services/issues/close_service_spec.rb | |
| parent | 772f2f1ac8aab40a2cd62f285af131eb61ad12bb (diff) | |
| download | gitlab-ce-466b768bb34730ee6a24d950333c232009c34bbd.tar.gz | |
Send notification emails to the "project", and put people in Cc
This fixes email threading in Mail.app, that doesn't like when a thread
doesn't have stable recipients.
For instance, here is a possible sender-recipient combinations before:
From: A
To: Me
New issue
From: B
To: Me
Reply on new issue
From: A
To: Me
Another reply
Mail.app doesn't see B as a participant to the original email thread,
and decides to break the thread: it will group all messages from A
together, and separately all messages from B.
This commit makes the thread look like this:
From: A
To: gitlab/project
Cc: Me
New issue
From: B
To: gitlab/project
Cc: Me
Reply on new issue
From: A
To: gitlab/project
Cc: Me
Another reply
Mail.app sees a common recipient, and group the thread correctly.
Diffstat (limited to 'spec/services/issues/close_service_spec.rb')
| -rw-r--r-- | spec/services/issues/close_service_spec.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/spec/services/issues/close_service_spec.rb b/spec/services/issues/close_service_spec.rb index d4f2cc1339b..7324650d534 100644 --- a/spec/services/issues/close_service_spec.rb +++ b/spec/services/issues/close_service_spec.rb @@ -22,7 +22,7 @@ describe Issues::CloseService do it 'should send email to user2 about assign of new issue' do email = ActionMailer::Base.deliveries.last - email.to.first.should == user2.email + email.cc.first.should == user2.email email.subject.should include(issue.title) end |