summaryrefslogtreecommitdiff
path: root/spec/services/notes
diff options
context:
space:
mode:
authorFelipe Artur <fcardozo@gitlab.com>2019-06-18 14:26:48 +0000
committerSean McGivern <sean@gitlab.com>2019-06-18 14:26:48 +0000
commit61bca6222ca8f605c49233508400f9b736ce9828 (patch)
treed1ffdd1fa4cfbaa01a8c5b25cdac3f5fe6aa3a17 /spec/services/notes
parent53036a5bc6dcdc120ce828e3366be8b4486f9a6a (diff)
downloadgitlab-ce-61bca6222ca8f605c49233508400f9b736ce9828.tar.gz
Move some quick actions feature specs to unit tests
Move some feature specs for issues/merge requests quick actions to unit tests. They are taking too long to run on the pipelines.
Diffstat (limited to 'spec/services/notes')
-rw-r--r--spec/services/notes/create_service_spec.rb147
1 files changed, 98 insertions, 49 deletions
diff --git a/spec/services/notes/create_service_spec.rb b/spec/services/notes/create_service_spec.rb
index 494ca95f66d..46abd8f356a 100644
--- a/spec/services/notes/create_service_spec.rb
+++ b/spec/services/notes/create_service_spec.rb
@@ -3,9 +3,9 @@
require 'spec_helper'
describe Notes::CreateService do
- let(:project) { create(:project) }
- let(:issue) { create(:issue, project: project) }
- let(:user) { create(:user) }
+ set(:project) { create(:project, :repository) }
+ set(:issue) { create(:issue, project: project) }
+ set(:user) { create(:user) }
let(:opts) do
{ note: 'Awesome comment', noteable_type: 'Issue', noteable_id: issue.id }
end
@@ -197,64 +197,113 @@ describe Notes::CreateService do
end
context 'note with commands' do
- context 'as a user who can update the target' do
- context '/close, /label, /assign & /milestone' do
- let(:note_text) { %(HELLO\n/close\n/assign @#{user.username}\nWORLD) }
-
- it 'saves the note and does not alter the note text' do
- service = double(:service)
- allow(Issues::UpdateService).to receive(:new).and_return(service)
- expect(service).to receive(:execute)
-
- note = described_class.new(project, user, opts.merge(note: note_text)).execute
-
- expect(note.note).to eq "HELLO\nWORLD"
+ context 'all quick actions' do
+ set(:milestone) { create(:milestone, project: project, title: "sprint") }
+ set(:bug_label) { create(:label, project: project, title: 'bug') }
+ set(:to_be_copied_label) { create(:label, project: project, title: 'to be copied') }
+ set(:feature_label) { create(:label, project: project, title: 'feature') }
+ set(:issue) { create(:issue, project: project, labels: [bug_label], due_date: '2019-01-01') }
+ set(:issue_2) { create(:issue, project: project, labels: [bug_label, to_be_copied_label]) }
+
+ context 'for issues' do
+ let(:issuable) { issue }
+ let(:note_params) { opts }
+ let(:issue_quick_actions) do
+ [
+ QuickAction.new(
+ action_text: '/confidential',
+ expectation: ->(noteable, can_use_quick_action) {
+ if can_use_quick_action
+ expect(noteable).to be_confidential
+ else
+ expect(noteable).not_to be_confidential
+ end
+ }
+ ),
+ QuickAction.new(
+ action_text: '/due 2016-08-28',
+ expectation: ->(noteable, can_use_quick_action) {
+ expect(noteable.due_date == Date.new(2016, 8, 28)).to eq(can_use_quick_action)
+ }
+ ),
+ QuickAction.new(
+ action_text: '/remove_due_date',
+ expectation: ->(noteable, can_use_quick_action) {
+ if can_use_quick_action
+ expect(noteable.due_date).to be_nil
+ else
+ expect(noteable.due_date).not_to be_nil
+ end
+ }
+ ),
+ QuickAction.new(
+ action_text: "/duplicate #{issue_2.to_reference}",
+ before_action: -> {
+ issuable.reopen
+ },
+ expectation: ->(noteable, can_use_quick_action) {
+ expect(noteable.closed?).to eq(can_use_quick_action)
+ }
+ )
+ ]
end
- end
- context '/merge with sha option' do
- let(:note_text) { %(HELLO\n/merge\nWORLD) }
- let(:params) { opts.merge(note: note_text, merge_request_diff_head_sha: 'sha') }
-
- it 'saves the note and exectues merge command' do
- note = described_class.new(project, user, params).execute
-
- expect(note.note).to eq "HELLO\nWORLD"
+ it_behaves_like 'issuable quick actions' do
+ let(:quick_actions) { issuable_quick_actions + issue_quick_actions }
end
end
- context 'when note only have commands' do
- it 'adds commands applied message to note errors' do
- note_text = %(/close)
- service = double(:service)
- allow(Issues::UpdateService).to receive(:new).and_return(service)
- expect(service).to receive(:execute)
-
- note = described_class.new(project, user, opts.merge(note: note_text)).execute
+ context 'for merge requests' do
+ set(:merge_request) { create(:merge_request, source_project: project, labels: [bug_label]) }
+ let(:issuable) { merge_request }
+ let(:note_params) { opts.merge(noteable_type: 'MergeRequest', noteable_id: merge_request.id) }
+ let(:merge_request_quick_actions) do
+ [
+ QuickAction.new(
+ action_text: "/target_branch fix",
+ expectation: ->(noteable, can_use_quick_action) {
+ expect(noteable.target_branch == "fix").to eq(can_use_quick_action)
+ }
+ ),
+ # Set WIP status
+ QuickAction.new(
+ action_text: "/wip",
+ before_action: -> {
+ issuable.reload.update(title: "title")
+ },
+ expectation: ->(issuable, can_use_quick_action) {
+ expect(issuable.work_in_progress?).to eq(can_use_quick_action)
+ }
+ ),
+ # Remove WIP status
+ QuickAction.new(
+ action_text: "/wip",
+ before_action: -> {
+ issuable.reload.update(title: "WIP: title")
+ },
+ expectation: ->(noteable, can_use_quick_action) {
+ expect(noteable.work_in_progress?).not_to eq(can_use_quick_action)
+ }
+ )
+ ]
+ end
- expect(note.errors[:commands_only]).to be_present
+ it_behaves_like 'issuable quick actions' do
+ let(:quick_actions) { issuable_quick_actions + merge_request_quick_actions }
end
end
end
- context 'as a user who cannot update the target' do
- let(:note_text) { "HELLO\n/todo\n/assign #{user.to_reference}\nWORLD" }
- let(:note) { described_class.new(project, user, opts.merge(note: note_text)).execute }
-
- before do
- project.team.find_member(user.id).update!(access_level: Gitlab::Access::GUEST)
- end
-
- it 'applies commands the user can execute' do
- expect { note }.to change { user.todos_pending_count }.from(0).to(1)
- end
+ context 'when note only have commands' do
+ it 'adds commands applied message to note errors' do
+ note_text = %(/close)
+ service = double(:service)
+ allow(Issues::UpdateService).to receive(:new).and_return(service)
+ expect(service).to receive(:execute)
- it 'does not apply commands the user cannot execute' do
- expect { note }.not_to change { issue.assignees }
- end
+ note = described_class.new(project, user, opts.merge(note: note_text)).execute
- it 'saves the note' do
- expect(note.note).to eq "HELLO\nWORLD"
+ expect(note.errors[:commands_only]).to be_present
end
end
end