diff options
author | GitLab Bot <gitlab-bot@gitlab.com> | 2020-02-20 09:09:13 +0000 |
---|---|---|
committer | GitLab Bot <gitlab-bot@gitlab.com> | 2020-02-20 09:09:13 +0000 |
commit | 1ac794623a8be5dee111716a44dd04ff708f3541 (patch) | |
tree | 6c18f9fbe0bd9978bd3e8d9b083d3a0ca180686e /spec/services/projects | |
parent | 5247fe0bef72fa922841a79d5dbefb47d95112fa (diff) | |
download | gitlab-ce-1ac794623a8be5dee111716a44dd04ff708f3541.tar.gz |
Add latest changes from gitlab-org/gitlab@master
Diffstat (limited to 'spec/services/projects')
-rw-r--r-- | spec/services/projects/fork_service_spec.rb | 55 |
1 files changed, 54 insertions, 1 deletions
diff --git a/spec/services/projects/fork_service_spec.rb b/spec/services/projects/fork_service_spec.rb index e14f1abf018..fa6d42369c8 100644 --- a/spec/services/projects/fork_service_spec.rb +++ b/spec/services/projects/fork_service_spec.rb @@ -275,6 +275,7 @@ describe Projects::ForkService do context 'fork project for group when user not owner' do it 'group developer fails to fork project into the group' do to_project = fork_project(@project, @developer, @opts) + expect(to_project.errors[:namespace]).to eq(['is not valid']) end end @@ -336,7 +337,9 @@ describe Projects::ForkService do context 'when linking fork to an existing project' do let(:fork_from_project) { create(:project, :public) } let(:fork_to_project) { create(:project, :public) } - let(:user) { create(:user) } + let(:user) do + create(:user).tap { |u| fork_to_project.add_maintainer(u) } + end subject { described_class.new(fork_from_project, user) } @@ -387,4 +390,54 @@ describe Projects::ForkService do end end end + + describe '#valid_fork_targets' do + let(:finder_mock) { instance_double('ForkTargetsFinder', execute: ['finder_return_value']) } + let(:current_user) { instance_double('User') } + let(:project) { instance_double('Project') } + + before do + allow(ForkTargetsFinder).to receive(:new).with(project, current_user).and_return(finder_mock) + end + + it 'returns whatever finder returns' do + expect(described_class.new(project, current_user).valid_fork_targets).to eq ['finder_return_value'] + end + end + + describe '#valid_fork_target?' do + subject { described_class.new(project, user, params).valid_fork_target? } + + let(:project) { Project.new } + let(:params) { {} } + + context 'when current user is an admin' do + let(:user) { build(:user, :admin) } + + it { is_expected.to be_truthy } + end + + context 'when current_user is not an admin' do + let(:user) { create(:user) } + + let(:finder_mock) { instance_double('ForkTargetsFinder', execute: [user.namespace]) } + let(:project) { create(:project) } + + before do + allow(ForkTargetsFinder).to receive(:new).with(project, user).and_return(finder_mock) + end + + context 'when target namespace is in valid fork targets' do + let(:params) { { namespace: user.namespace } } + + it { is_expected.to be_truthy } + end + + context 'when target namespace is not in valid fork targets' do + let(:params) { { namespace: create(:group) } } + + it { is_expected.to be_falsey } + end + end + end end |