summaryrefslogtreecommitdiff
path: root/spec/services/system_note_service_spec.rb
diff options
context:
space:
mode:
authorSean McGivern <sean@mcgivern.me.uk>2016-12-06 14:04:14 +0000
committerSean McGivern <sean@mcgivern.me.uk>2016-12-06 14:04:14 +0000
commitd9ef41cf4dd89716854ef27c4c6cbd93746e426a (patch)
tree4832a35d5cb7fa34b6ba4fdd06ada89dd123b33b /spec/services/system_note_service_spec.rb
parente1198d4fe5cc24b6d3ca1368dd2300c9f4351cb5 (diff)
parent1123057ab792ac73b1611f4d3a9faf79369dd6da (diff)
downloadgitlab-ce-d9ef41cf4dd89716854ef27c4c6cbd93746e426a.tar.gz
Merge branch '23589-open-issue-for-mr' into 'master'
Create an issue for all unresolved discussions in an MR See merge request !7180
Diffstat (limited to 'spec/services/system_note_service_spec.rb')
-rw-r--r--spec/services/system_note_service_spec.rb28
1 files changed, 28 insertions, 0 deletions
diff --git a/spec/services/system_note_service_spec.rb b/spec/services/system_note_service_spec.rb
index 4bffe622d72..90b7e62bc6f 100644
--- a/spec/services/system_note_service_spec.rb
+++ b/spec/services/system_note_service_spec.rb
@@ -712,4 +712,32 @@ describe SystemNoteService, services: true do
end
end
end
+
+ describe '.discussion_continued_in_issue' do
+ let(:discussion) { Discussion.for_diff_notes([create(:diff_note_on_merge_request)]).first }
+ let(:merge_request) { discussion.noteable }
+ let(:project) { merge_request.source_project }
+ let(:issue) { create(:issue, project: project) }
+ let(:user) { create(:user) }
+
+ def reloaded_merge_request
+ MergeRequest.find(merge_request.id)
+ end
+
+ before do
+ project.team << [user, :developer]
+ end
+
+ it 'creates a new note in the discussion' do
+ # we need to completely rebuild the merge request object, or the `@discussions` on the merge request are not reloaded.
+ expect { SystemNoteService.discussion_continued_in_issue(discussion, project, user, issue) }.
+ to change { reloaded_merge_request.discussions.first.notes.size }.by(1)
+ end
+
+ it 'mentions the created issue in the system note' do
+ note = SystemNoteService.discussion_continued_in_issue(discussion, project, user, issue)
+
+ expect(note.note).to include(issue.to_reference)
+ end
+ end
end