diff options
| author | Douglas Barbosa Alexandre <dbalexandre@gmail.com> | 2016-03-16 20:31:30 -0300 |
|---|---|---|
| committer | Douglas Barbosa Alexandre <dbalexandre@gmail.com> | 2016-03-18 11:00:53 -0300 |
| commit | c29da3f8ca1d759b8cbecb91b6e0529b18cc5c85 (patch) | |
| tree | b60d38cea7b271f52307ec48df1a14327915edda /spec/services/todo_service_spec.rb | |
| parent | 1e76245d4e8c5ecbd915c517b6c8923e9c4bbd2d (diff) | |
| download | gitlab-ce-c29da3f8ca1d759b8cbecb91b6e0529b18cc5c85.tar.gz | |
Trigger a todo for mentions on commits page
Diffstat (limited to 'spec/services/todo_service_spec.rb')
| -rw-r--r-- | spec/services/todo_service_spec.rb | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/spec/services/todo_service_spec.rb b/spec/services/todo_service_spec.rb index 96420acb31d..b4728807b8b 100644 --- a/spec/services/todo_service_spec.rb +++ b/spec/services/todo_service_spec.rb @@ -148,8 +148,13 @@ describe TodoService, services: true do should_not_create_todo(user: stranger, target: issue, author: john_doe, action: Todo::MENTIONED, note: note) end - it 'does not create todo when leaving a note on commit' do - should_not_create_any_todo { service.new_note(note_on_commit, john_doe) } + it 'creates a todo for each valid mentioned user when leaving a note on commit' do + service.new_note(note_on_commit, john_doe) + + should_create_todo(user: michael, target_id: nil, target_type: 'Commit', commit_id: note_on_commit.commit_id, author: john_doe, action: Todo::MENTIONED, note: note_on_commit) + should_create_todo(user: author, target_id: nil, target_type: 'Commit', commit_id: note_on_commit.commit_id, author: john_doe, action: Todo::MENTIONED, note: note_on_commit) + should_not_create_todo(user: john_doe, target_id: nil, target_type: 'Commit', commit_id: note_on_commit.commit_id, author: john_doe, action: Todo::MENTIONED, note: note_on_commit) + should_not_create_todo(user: stranger, target_id: nil, target_type: 'Commit', commit_id: note_on_commit.commit_id, author: john_doe, action: Todo::MENTIONED, note: note_on_commit) end it 'does not create todo when leaving a note on snippet' do |