diff options
author | Kamil Trzcinski <ayufan@ayufan.eu> | 2017-02-28 19:23:35 +0100 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2017-03-01 00:07:56 -0800 |
commit | ec100a2004c9c4703e7074ca369ad843c631f660 (patch) | |
tree | 2fce8061a44353258ac5c501c7b35aafd2b17796 /spec/services | |
parent | ad00b9bc60f2204419bf21ad62c811f59ee5ead3 (diff) | |
download | gitlab-ce-ec100a2004c9c4703e7074ca369ad843c631f660.tar.gz |
Fix concurrent access on builds/register
Diffstat (limited to 'spec/services')
-rw-r--r-- | spec/services/ci/register_build_service_spec.rb | 45 |
1 files changed, 45 insertions, 0 deletions
diff --git a/spec/services/ci/register_build_service_spec.rb b/spec/services/ci/register_build_service_spec.rb index d9f774a1095..cd7dd53025c 100644 --- a/spec/services/ci/register_build_service_spec.rb +++ b/spec/services/ci/register_build_service_spec.rb @@ -170,6 +170,51 @@ module Ci end end + context 'when first build is stalled' do + before do + pending_build.lock_version = 10 + end + + subject { described_class.new(specific_runner).execute } + + context 'with multiple builds are in queue' do + let!(:other_build) { create :ci_build, pipeline: pipeline } + + before do + allow_any_instance_of(Ci::RegisterBuildService).to receive(:builds_for_specific_runner) + .and_return([pending_build, other_build]) + end + + it "receives second build from the queue" do + expect(subject).to be_valid + expect(subject.build).to eq(other_build) + end + end + + context 'when single build is in queue' do + before do + allow_any_instance_of(Ci::RegisterBuildService).to receive(:builds_for_specific_runner) + .and_return([pending_build]) + end + + it "does not receive any valid result" do + expect(subject).not_to be_valid + end + end + + context 'when there is no build in queue' do + before do + allow_any_instance_of(Ci::RegisterBuildService).to receive(:builds_for_specific_runner) + .and_return([]) + end + + it "does not receive builds but result is valid" do + expect(subject).to be_valid + expect(subject.build).to be_nil + end + end + end + def execute(runner) described_class.new(runner).execute.build end |