Fix Groups::UpdateService#execute not returning correct error code

This was causing problems in EE, where audit events were being
generated even if the project failed to save.

1 files changed, 6 insertions, 0 deletions

diff --git a/spec/services/groups/update_service_spec.rb b/spec/services/groups/update_service_spec.rb
index 7c5c7409cc1..84cfa53ea05 100644
--- a/spec/services/groups/update_service_spec.rb
+++ b/spec/services/groups/update_service_spec.rb
@@ -24,6 +24,12 @@ describe Groups::UpdateService do
 
           expect(TodosDestroyer::GroupPrivateWorker).not_to receive(:perform_in)
         end
+
+        it "returns false if save failed" do
+          allow(public_group).to receive(:save).and_return(false)
+
+          expect(service.execute).to be_falsey
+        end
       end
 
       context "internal group with internal project" do