diff options
author | Shinya Maeda <gitlab.shinyamaeda@gmail.com> | 2017-06-06 02:29:34 +0900 |
---|---|---|
committer | Shinya Maeda <shinya@gitlab.com> | 2017-06-28 21:58:31 +0900 |
commit | 359d72ba3ec931205a58b4a992cc9b6e93fd0ca2 (patch) | |
tree | 824c7ea525868e800608f5fd7ad1465705cd4be1 /spec/support/matchers | |
parent | e9734c6df33dba7ab89d4c575ace3a508c5da64b (diff) | |
download | gitlab-ce-359d72ba3ec931205a58b4a992cc9b6e93fd0ca2.tar.gz |
Fix static analysys
Diffstat (limited to 'spec/support/matchers')
-rw-r--r-- | spec/support/matchers/access_matchers_for_controller.rb | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/spec/support/matchers/access_matchers_for_controller.rb b/spec/support/matchers/access_matchers_for_controller.rb index 14500201a59..12f4b57e43d 100644 --- a/spec/support/matchers/access_matchers_for_controller.rb +++ b/spec/support/matchers/access_matchers_for_controller.rb @@ -5,14 +5,22 @@ module AccessMatchersForController extend RSpec::Matchers::DSL include Warden::Test::Helpers - EXPECTED_STATUS_CODE_ALLOWED = [200, 302] - EXPECTED_STATUS_CODE_DENIED = [404] + EXPECTED_STATUS_CODE_ALLOWED = [200, 302].freeze + EXPECTED_STATUS_CODE_DENIED = [404].freeze def emulate_user(role, membership = nil) case role when :admin user = create(:admin) sign_in(user) + when :user + user = create(:user) + sign_in(user) + when :external + user = create(:user, external: true) + sign_in(user) + when :visitor # rubocop:disable Lint/EmptyWhen + # no-op when *Gitlab::Access.sym_options_with_owner.keys # owner, master, developer, reporter, guest raise ArgumentError, "cannot emulate #{role} without membership parent" unless membership @@ -24,14 +32,6 @@ module AccessMatchersForController end sign_in(user) - when :user - user = create(:user) - sign_in(user) - when :external - user = create(:user, external: true) - sign_in(user) - when :visitor - # no-op else raise ArgumentError, "cannot emulate user #{role}" end |