Add latest changes from gitlab-org/gitlab@13-0-stable-ee

3 files changed, 242 insertions, 0 deletions

diff --git a/spec/support/shared_examples/services/wiki_pages/create_service_shared_examples.rb b/spec/support/shared_examples/services/wiki_pages/create_service_shared_examples.rb
new file mode 100644
index 00000000000..71bdd46572f
--- /dev/null
+++ b/spec/support/shared_examples/services/wiki_pages/create_service_shared_examples.rb
@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'WikiPages::CreateService#execute' do |container_type|
+  let(:container) { create(container_type, :wiki_repo) }
+  let(:user) { create(:user) }
+  let(:page_title) { 'Title' }
+
+  let(:opts) do
+    {
+      title: page_title,
+      content: 'Content for wiki page',
+      format: 'markdown'
+    }
+  end
+
+  subject(:service) { described_class.new(container: container, current_user: user, params: opts) }
+
+  it 'creates wiki page with valid attributes' do
+    page = service.execute
+
+    expect(page).to be_valid
+    expect(page).to be_persisted
+    expect(page.title).to eq(opts[:title])
+    expect(page.content).to eq(opts[:content])
+    expect(page.format).to eq(opts[:format].to_sym)
+  end
+
+  it 'executes webhooks' do
+    expect(service).to receive(:execute_hooks).once.with(WikiPage)
+
+    service.execute
+  end
+
+  it 'counts wiki page creation' do
+    counter = Gitlab::UsageDataCounters::WikiPageCounter
+
+    expect { service.execute }.to change { counter.read(:create) }.by 1
+  end
+
+  shared_examples 'correct event created' do
+    it 'creates appropriate events' do
+      # TODO: https://gitlab.com/gitlab-org/gitlab/-/issues/216904
+      pending('group wiki support') if container_type == :group
+
+      expect { service.execute }.to change { Event.count }.by 1
+
+      expect(Event.recent.first).to have_attributes(
+        action: Event::CREATED,
+        target: have_attributes(canonical_slug: page_title)
+      )
+    end
+  end
+
+  context 'the new page is at the top level' do
+    let(:page_title) { 'root-level-page' }
+
+    include_examples 'correct event created'
+  end
+
+  context 'the new page is in a subsection' do
+    let(:page_title) { 'subsection/page' }
+
+    include_examples 'correct event created'
+  end
+
+  context 'the feature is disabled' do
+    before do
+      stub_feature_flags(wiki_events: false)
+    end
+
+    it 'does not record the activity' do
+      expect { service.execute }.not_to change(Event, :count)
+    end
+  end
+
+  context 'when the options are bad' do
+    let(:page_title) { '' }
+
+    it 'does not count a creation event' do
+      counter = Gitlab::UsageDataCounters::WikiPageCounter
+
+      expect { service.execute }.not_to change { counter.read(:create) }
+    end
+
+    it 'does not record the activity' do
+      expect { service.execute }.not_to change(Event, :count)
+    end
+
+    it 'reports the error' do
+      expect(service.execute).to be_invalid
+        .and have_attributes(errors: be_present)
+    end
+  end
+end
diff --git a/spec/support/shared_examples/services/wiki_pages/destroy_service_shared_examples.rb b/spec/support/shared_examples/services/wiki_pages/destroy_service_shared_examples.rb
new file mode 100644
index 00000000000..62541eb3da9
--- /dev/null
+++ b/spec/support/shared_examples/services/wiki_pages/destroy_service_shared_examples.rb
@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'WikiPages::DestroyService#execute' do |container_type|
+  let(:container) { create(container_type) }
+
+  let(:user) { create(:user) }
+  let(:page) { create(:wiki_page) }
+
+  subject(:service) { described_class.new(container: container, current_user: user) }
+
+  it 'executes webhooks' do
+    expect(service).to receive(:execute_hooks).once.with(page)
+
+    service.execute(page)
+  end
+
+  it 'increments the delete count' do
+    counter = Gitlab::UsageDataCounters::WikiPageCounter
+
+    expect { service.execute(page) }.to change { counter.read(:delete) }.by 1
+  end
+
+  it 'creates a new wiki page deletion event' do
+    # TODO: https://gitlab.com/gitlab-org/gitlab/-/issues/216904
+    pending('group wiki support') if container_type == :group
+
+    expect { service.execute(page) }.to change { Event.count }.by 1
+
+    expect(Event.recent.first).to have_attributes(
+      action: Event::DESTROYED,
+      target: have_attributes(canonical_slug: page.slug)
+    )
+  end
+
+  it 'does not increment the delete count if the deletion failed' do
+    counter = Gitlab::UsageDataCounters::WikiPageCounter
+
+    expect { service.execute(nil) }.not_to change { counter.read(:delete) }
+  end
+
+  context 'the feature is disabled' do
+    before do
+      stub_feature_flags(wiki_events: false)
+    end
+
+    it 'does not record the activity' do
+      expect { service.execute(page) }.not_to change(Event, :count)
+    end
+  end
+end
diff --git a/spec/support/shared_examples/services/wiki_pages/update_service_shared_examples.rb b/spec/support/shared_examples/services/wiki_pages/update_service_shared_examples.rb
new file mode 100644
index 00000000000..0dfc99d043b
--- /dev/null
+++ b/spec/support/shared_examples/services/wiki_pages/update_service_shared_examples.rb
@@ -0,0 +1,98 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples 'WikiPages::UpdateService#execute' do |container_type|
+  let(:container) { create(container_type, :wiki_repo) }
+
+  let(:user) { create(:user) }
+  let(:page) { create(:wiki_page) }
+  let(:page_title) { 'New Title' }
+
+  let(:opts) do
+    {
+      content: 'New content for wiki page',
+      format: 'markdown',
+      message: 'New wiki message',
+      title: page_title
+    }
+  end
+
+  subject(:service) { described_class.new(container: container, current_user: user, params: opts) }
+
+  it 'updates the wiki page' do
+    updated_page = service.execute(page)
+
+    expect(updated_page).to be_valid
+    expect(updated_page.message).to eq(opts[:message])
+    expect(updated_page.content).to eq(opts[:content])
+    expect(updated_page.format).to eq(opts[:format].to_sym)
+    expect(updated_page.title).to eq(page_title)
+  end
+
+  it 'executes webhooks' do
+    expect(service).to receive(:execute_hooks).once.with(WikiPage)
+
+    service.execute(page)
+  end
+
+  it 'counts edit events' do
+    counter = Gitlab::UsageDataCounters::WikiPageCounter
+
+    expect { service.execute page }.to change { counter.read(:update) }.by 1
+  end
+
+  shared_examples 'adds activity event' do
+    it 'adds a new wiki page activity event' do
+      # TODO: https://gitlab.com/gitlab-org/gitlab/-/issues/216904
+      pending('group wiki support') if container_type == :group
+
+      expect { service.execute(page) }.to change { Event.count }.by 1
+
+      expect(Event.recent.first).to have_attributes(
+        action: Event::UPDATED,
+        wiki_page: page,
+        target_title: page.title
+      )
+    end
+  end
+
+  context 'the page is at the top level' do
+    let(:page_title) { 'Top level page' }
+
+    include_examples 'adds activity event'
+  end
+
+  context 'the page is in a subsection' do
+    let(:page_title) { 'Subsection / secondary page' }
+
+    include_examples 'adds activity event'
+  end
+
+  context 'the feature is disabled' do
+    before do
+      stub_feature_flags(wiki_events: false)
+    end
+
+    it 'does not record the activity' do
+      expect { service.execute(page) }.not_to change(Event, :count)
+    end
+  end
+
+  context 'when the options are bad' do
+    let(:page_title) { '' }
+
+    it 'does not count an edit event' do
+      counter = Gitlab::UsageDataCounters::WikiPageCounter
+
+      expect { service.execute page }.not_to change { counter.read(:update) }
+    end
+
+    it 'does not record the activity' do
+      expect { service.execute page }.not_to change(Event, :count)
+    end
+
+    it 'reports the error' do
+      expect(service.execute(page)).to be_invalid
+        .and have_attributes(errors: be_present)
+    end
+  end
+end