diff options
author | Matija Čupić <matteeyah@gmail.com> | 2018-02-05 15:23:32 +0100 |
---|---|---|
committer | Matija Čupić <matteeyah@gmail.com> | 2018-02-05 18:58:21 +0100 |
commit | 79570ce24fa93709db7a7bdd4fae2532a7235486 (patch) | |
tree | ce9bd4dbce252fdc71441e02896bd4f47e5e1105 /spec/support | |
parent | f7ed096455c932a5ead8bafb8c937ff9cdb3070c (diff) | |
download | gitlab-ce-79570ce24fa93709db7a7bdd4fae2532a7235486.tar.gz |
Fix validation of duplicate new variablesdynamic-pipeline-variables
Diffstat (limited to 'spec/support')
-rw-r--r-- | spec/support/shared_examples/controllers/variables_shared_examples.rb | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/spec/support/shared_examples/controllers/variables_shared_examples.rb b/spec/support/shared_examples/controllers/variables_shared_examples.rb index 3f1690e71dd..d7acf8c0032 100644 --- a/spec/support/shared_examples/controllers/variables_shared_examples.rb +++ b/spec/support/shared_examples/controllers/variables_shared_examples.rb @@ -48,6 +48,29 @@ shared_examples 'PATCH #update updates variables' do end end + context 'with duplicate new variable parameters' do + let(:variables_attributes) do + [ + new_variable_attributes, + new_variable_attributes.merge(value: 'other_value') + ] + end + + it 'does not update the existing variable' do + expect { subject }.not_to change { variable.reload.value } + end + + it 'does not create the new variable' do + expect { subject }.not_to change { owner.variables.count } + end + + it 'returns a bad request response' do + subject + + expect(response).to have_gitlab_http_status(:bad_request) + end + end + context 'with valid new variable parameters' do let(:variables_attributes) do [ |