diff options
author | Rémy Coutable <remy@rymai.me> | 2017-08-02 09:46:11 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2017-08-02 09:46:11 +0000 |
commit | db17b3c7cd06a3296983b2a496e61c23564a0977 (patch) | |
tree | c99ec01f7b313885870e4582b9a02324d53ea472 /spec/support | |
parent | 0bc1dfb6d5a3af73f91338d460d67adbb5b3a5fc (diff) | |
parent | 939e9bdde144849cbc11091985bca0a27f6e75ac (diff) | |
download | gitlab-ce-db17b3c7cd06a3296983b2a496e61c23564a0977.tar.gz |
Merge branch 'rs-issuables-list-metadata-shared-examples' into 'master'
Make the 'issuables list meta-data' shared example less dangerous
See merge request !13236
Diffstat (limited to 'spec/support')
-rw-r--r-- | spec/support/issuables_list_metadata_shared_examples.rb | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/spec/support/issuables_list_metadata_shared_examples.rb b/spec/support/issuables_list_metadata_shared_examples.rb index 3406e4c3161..1004c895bb4 100644 --- a/spec/support/issuables_list_metadata_shared_examples.rb +++ b/spec/support/issuables_list_metadata_shared_examples.rb @@ -11,10 +11,6 @@ shared_examples 'issuables list meta-data' do |issuable_type, action = nil| end @issuable_ids << issuable.id - - issuable.id.times { create(:note, noteable: issuable, project: issuable.project) } - (issuable.id + 1).times { create(:award_emoji, :downvote, awardable: issuable) } - (issuable.id + 2).times { create(:award_emoji, :upvote, awardable: issuable) } end end @@ -27,10 +23,9 @@ shared_examples 'issuables list meta-data' do |issuable_type, action = nil| meta_data = assigns(:issuable_meta_data) - @issuable_ids.each do |id| - expect(meta_data[id].notes_count).to eq(id) - expect(meta_data[id].downvotes).to eq(id + 1) - expect(meta_data[id].upvotes).to eq(id + 2) + aggregate_failures do + expect(meta_data.keys).to match_array(@issuable_ids) + expect(meta_data.values).to all(be_kind_of(Issuable::IssuableMeta)) end end |