diff options
author | Rémy Coutable <remy@rymai.me> | 2017-03-08 12:23:53 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2017-03-08 12:23:53 +0000 |
commit | 685e261f0a9f2495b29e552489e174987101f1f9 (patch) | |
tree | 5fb11373434c27c75a9cd5712bbfb18032abfc02 /spec/views | |
parent | e78a366925553a1268f8dc6e0d57342053a3240a (diff) | |
parent | b5b448934563b0b3237b6b2e6e168c012b012097 (diff) | |
download | gitlab-ce-685e261f0a9f2495b29e552489e174987101f1f9.tar.gz |
Merge branch '26188-tag-creation-404-for-guests' into 'master'
Don't show links to tag a commit for non permitted users
Closes #26188
See merge request !8407
Diffstat (limited to 'spec/views')
-rw-r--r-- | spec/views/projects/commit/_commit_box.html.haml_spec.rb | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/spec/views/projects/commit/_commit_box.html.haml_spec.rb b/spec/views/projects/commit/_commit_box.html.haml_spec.rb index e741e3cf9b6..f2919f20e85 100644 --- a/spec/views/projects/commit/_commit_box.html.haml_spec.rb +++ b/spec/views/projects/commit/_commit_box.html.haml_spec.rb @@ -3,11 +3,13 @@ require 'spec_helper' describe 'projects/commit/_commit_box.html.haml' do include Devise::Test::ControllerHelpers + let(:user) { create(:user) } let(:project) { create(:project) } before do assign(:project, project) assign(:commit, project.commit) + allow(view).to receive(:can_collaborate_with_project?).and_return(false) end it 'shows the commit SHA' do @@ -25,4 +27,30 @@ describe 'projects/commit/_commit_box.html.haml' do expect(rendered).to have_text("Pipeline ##{third_pipeline.id} for #{Commit.truncate_sha(project.commit.sha)} failed") end + + context 'viewing a commit' do + context 'as a developer' do + before do + expect(view).to receive(:can_collaborate_with_project?).and_return(true) + end + + it 'has a link to create a new tag' do + render + + expect(rendered).to have_link('Tag') + end + end + + context 'as a non-developer' do + before do + expect(view).to receive(:can_collaborate_with_project?).and_return(false) + end + + it 'does not have a link to create a new tag' do + render + + expect(rendered).not_to have_link('Tag') + end + end + end end |