diff options
author | Nick Thomas <nick@gitlab.com> | 2016-10-17 13:40:02 +0100 |
---|---|---|
committer | Nick Thomas <nick@gitlab.com> | 2016-10-17 14:44:20 +0100 |
commit | bfb20200e9d1e7edd82a27d18d849ffba043845a (patch) | |
tree | 28f614cb61db165c8ebf1524d981e91755bec17f /spec/workers/pipeline_metrics_worker_spec.rb | |
parent | 77507df6030dad9e317e092c70003d4c85d8f889 (diff) | |
download | gitlab-ce-bfb20200e9d1e7edd82a27d18d849ffba043845a.tar.gz |
Add a be_like_time matcher and use it in specs
The amount of precision times have in databases is variable, so we need
tolerances when comparing in specs. It's better to have the tolerance defined
in one place than several.
Diffstat (limited to 'spec/workers/pipeline_metrics_worker_spec.rb')
-rw-r--r-- | spec/workers/pipeline_metrics_worker_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/workers/pipeline_metrics_worker_spec.rb b/spec/workers/pipeline_metrics_worker_spec.rb index 232478c9735..2c9e7c2cd02 100644 --- a/spec/workers/pipeline_metrics_worker_spec.rb +++ b/spec/workers/pipeline_metrics_worker_spec.rb @@ -23,7 +23,7 @@ describe PipelineMetricsWorker do it 'records the build start time' do subject - expect(merge_request.reload.metrics.latest_build_started_at).to be_within(1.second).of(pipeline.started_at) + expect(merge_request.reload.metrics.latest_build_started_at).to be_like_time(pipeline.started_at) end it 'clears the build end time' do @@ -39,7 +39,7 @@ describe PipelineMetricsWorker do it 'records the build end time' do subject - expect(merge_request.reload.metrics.latest_build_finished_at).to be_within(1.second).of(pipeline.finished_at) + expect(merge_request.reload.metrics.latest_build_finished_at).to be_like_time(pipeline.finished_at) end end end |