diff options
author | mhasbini <mohammad.hasbini@gmail.com> | 2017-04-04 13:54:58 +0300 |
---|---|---|
committer | mhasbini <mohammad.hasbini@gmail.com> | 2017-04-04 13:54:58 +0300 |
commit | e52b1df1d5391f0fa0b9ec7eb2d3492b05f64ba4 (patch) | |
tree | c9fbd2c57dae0a5872653d3df0b9a681a5441404 /spec/workers | |
parent | 9fc17f6f4abdb04f3cf1b60b87bd67b894a19c39 (diff) | |
download | gitlab-ce-e52b1df1d5391f0fa0b9ec7eb2d3492b05f64ba4.tar.gz |
Remove useless queries with false conditions (e.g 1=0)
Diffstat (limited to 'spec/workers')
-rw-r--r-- | spec/workers/process_commit_worker_spec.rb | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/spec/workers/process_commit_worker_spec.rb b/spec/workers/process_commit_worker_spec.rb index 1c383d0514d..9afe2e610b9 100644 --- a/spec/workers/process_commit_worker_spec.rb +++ b/spec/workers/process_commit_worker_spec.rb @@ -99,6 +99,13 @@ describe ProcessCommitWorker do expect(metric.first_mentioned_in_commit_at).to eq(commit.committed_date) end + + it "doesn't execute any queries with false conditions" do + allow(commit).to receive(:safe_message). + and_return("Lorem Ipsum") + + expect { worker.update_issue_metrics(commit, user) }.not_to make_queries_matching(/WHERE (?:1=0|0=1)/) + end end describe '#build_commit' do |