diff options
author | Tiger <twatson@gitlab.com> | 2019-04-11 13:26:10 +1000 |
---|---|---|
committer | Tiger <twatson@gitlab.com> | 2019-05-16 20:18:42 -0500 |
commit | fa5a6ae172584c5c33665a6efa4a6aa4efaea9ad (patch) | |
tree | e24b9715ffd352f5285b46c4f1780ec2b173f141 /spec/workers | |
parent | e9ed028472747422670fed448624bb3e067fb4e2 (diff) | |
download | gitlab-ce-fa5a6ae172584c5c33665a6efa4a6aa4efaea9ad.tar.gz |
Stop configuring group clusters on creation60379-remove-ci-preparing-state-feature-flag
Immediate configuration is not ideal for group and instance
level clusters as projects that may never be deployed would
still have Kubernetes namespaces and service accounts created
for them.
As of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25586
we now create only the resources that are required for the
project being deployed, at the time of deployment.
Diffstat (limited to 'spec/workers')
-rw-r--r-- | spec/workers/cluster_configure_worker_spec.rb | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/spec/workers/cluster_configure_worker_spec.rb b/spec/workers/cluster_configure_worker_spec.rb index daf014ac574..975088f3ee6 100644 --- a/spec/workers/cluster_configure_worker_spec.rb +++ b/spec/workers/cluster_configure_worker_spec.rb @@ -4,11 +4,6 @@ require 'spec_helper' describe ClusterConfigureWorker, '#perform' do let(:worker) { described_class.new } - let(:ci_preparing_state_enabled) { false } - - before do - stub_feature_flags(ci_preparing_state: ci_preparing_state_enabled) - end shared_examples 'configured cluster' do it 'creates a namespace' do @@ -33,26 +28,14 @@ describe ClusterConfigureWorker, '#perform' do context 'when group has a project' do let!(:project) { create(:project, group: group) } - it_behaves_like 'configured cluster' - - context 'ci_preparing_state feature is enabled' do - let(:ci_preparing_state_enabled) { true } - - it_behaves_like 'unconfigured cluster' - end + it_behaves_like 'unconfigured cluster' end context 'when group has project in a sub-group' do let!(:subgroup) { create(:group, parent: group) } let!(:project) { create(:project, group: subgroup) } - it_behaves_like 'configured cluster' - - context 'ci_preparing_state feature is enabled' do - let(:ci_preparing_state_enabled) { true } - - it_behaves_like 'unconfigured cluster' - end + it_behaves_like 'unconfigured cluster' end end |