Refactor ExpirePipelineCacheWorker#perform

Make it gracefully handle unexisting pipelines and refactor iterating
all the merge request paths.

1 files changed, 6 insertions, 0 deletions

diff --git a/spec/workers/expire_pipeline_cache_worker_spec.rb b/spec/workers/expire_pipeline_cache_worker_spec.rb
index 67f01539ada..58f587f6d11 100644
--- a/spec/workers/expire_pipeline_cache_worker_spec.rb
+++ b/spec/workers/expire_pipeline_cache_worker_spec.rb
@@ -29,6 +29,12 @@ describe ExpirePipelineCacheWorker do
       subject.perform(pipeline.id)
     end
 
+    it "doesn't do anything if the pipeline not exist" do
+      expect_any_instance_of(Gitlab::EtagCaching::Store).not_to receive(:touch)
+
+      subject.perform(617748)
+    end
+
     it 'updates the cached status for a project' do
       expect(Gitlab::Cache::Ci::ProjectPipelineStatus).to receive(:update_for_pipeline).
                                                             with(pipeline)