summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorAlexander Randa <randa.alex@gmail.com>2017-08-01 17:30:29 +0300
committerAlexander Randa <randa.alex@gmail.com>2017-08-01 20:19:59 +0300
commit0135d57b017e4b044511249d534bd26ab77c063d (patch)
tree48ef0c366851f0eaf56540fe2018873fe3f96ea1 /spec
parent1ec24154aabc2e25fc0c9f742ea23a075a1d9ed8 (diff)
downloadgitlab-ce-0135d57b017e4b044511249d534bd26ab77c063d.tar.gz
Fix encoding error for WebHook logging
Diffstat (limited to 'spec')
-rw-r--r--spec/services/web_hook_service_spec.rb17
1 files changed, 17 insertions, 0 deletions
diff --git a/spec/services/web_hook_service_spec.rb b/spec/services/web_hook_service_spec.rb
index e79c12daa1c..0d710db812c 100644
--- a/spec/services/web_hook_service_spec.rb
+++ b/spec/services/web_hook_service_spec.rb
@@ -112,6 +112,23 @@ describe WebHookService do
end
end
+ context 'with unsafe response body' do
+ before do
+ WebMock.stub_request(:post, project_hook.url).to_return(status: 200, body: "\xBB")
+ service_instance.execute
+ end
+
+ it 'log successful execution' do
+ expect(hook_log.trigger).to eq('push_hooks')
+ expect(hook_log.url).to eq(project_hook.url)
+ expect(hook_log.request_headers).to eq(headers)
+ expect(hook_log.response_body).to eq('')
+ expect(hook_log.response_status).to eq('200')
+ expect(hook_log.execution_duration).to be > 0
+ expect(hook_log.internal_error_message).to be_nil
+ end
+ end
+
context 'should not log ServiceHooks' do
let(:service_hook) { create(:service_hook) }
let(:service_instance) { described_class.new(service_hook, data, 'service_hook') }