Remove Redcarpet markdown engine

This engine was replaced with CommonMarker in 11.4, it was deprecated
since then.

15 files changed, 105 insertions, 458 deletions

diff --git a/spec/features/markdown/markdown_spec.rb b/spec/features/markdown/markdown_spec.rb
index 3b37ede8579..8815643ca96 100644
--- a/spec/features/markdown/markdown_spec.rb
+++ b/spec/features/markdown/markdown_spec.rb
@@ -13,7 +13,7 @@ require 'erb'
 #
 #   Raw Markdown
 #   -> `markdown` helper
-#     -> Redcarpet::Render::GitlabHTML converts Markdown to HTML
+#     -> CommonMark::Render::GitlabHTML converts Markdown to HTML
 #       -> Post-process HTML
 #         -> `gfm` helper
 #           -> HTML::Pipeline
@@ -324,31 +324,6 @@ describe 'GitLab Markdown', :aggregate_failures do
     end
   end
 
-  context 'Redcarpet documents' do
-    before do
-      allow_any_instance_of(Banzai::Filter::MarkdownFilter).to receive(:engine).and_return('Redcarpet')
-      @html = markdown(@feat.raw_markdown)
-    end
-
-    it 'processes certain elements differently' do
-      aggregate_failures 'parses superscript' do
-        expect(doc).to have_selector('sup', count: 3)
-      end
-
-      aggregate_failures 'permits style attribute in th elements' do
-        expect(doc.at_css('th:contains("Header")')['style']).to eq 'text-align: center'
-        expect(doc.at_css('th:contains("Row")')['style']).to eq 'text-align: right'
-        expect(doc.at_css('th:contains("Example")')['style']).to eq 'text-align: left'
-      end
-
-      aggregate_failures 'permits style attribute in td elements' do
-        expect(doc.at_css('td:contains("Foo")')['style']).to eq 'text-align: center'
-        expect(doc.at_css('td:contains("Bar")')['style']).to eq 'text-align: right'
-        expect(doc.at_css('td:contains("Baz")')['style']).to eq 'text-align: left'
-      end
-    end
-  end
-
   # Fake a `current_user` helper
   def current_user
     @feat.user
diff --git a/spec/features/projects/blobs/blob_show_spec.rb b/spec/features/projects/blobs/blob_show_spec.rb
index e2f9e7e9cc5..3edcc7ac2cd 100644
--- a/spec/features/projects/blobs/blob_show_spec.rb
+++ b/spec/features/projects/blobs/blob_show_spec.rb
@@ -5,8 +5,8 @@ describe 'File blob', :js do
 
   let(:project) { create(:project, :public, :repository) }
 
-  def visit_blob(path, anchor: nil, ref: 'master', legacy_render: nil)
-    visit project_blob_path(project, File.join(ref, path), anchor: anchor, legacy_render: legacy_render)
+  def visit_blob(path, anchor: nil, ref: 'master')
+    visit project_blob_path(project, File.join(ref, path), anchor: anchor)
 
     wait_for_requests
   end
@@ -171,21 +171,6 @@ describe 'File blob', :js do
         end
       end
     end
-
-    context 'when rendering legacy markdown' do
-      before do
-        visit_blob('files/commonmark/file.md', legacy_render: 1)
-
-        wait_for_requests
-      end
-
-      it 'renders using RedCarpet' do
-        aggregate_failures do
-          expect(page).to have_content("sublist")
-          expect(page).to have_xpath("//ol//li//ul")
-        end
-      end
-    end
   end
 
   context 'Markdown file (stored in LFS)' do
diff --git a/spec/features/projects/blobs/edit_spec.rb b/spec/features/projects/blobs/edit_spec.rb
index d5b20605860..6e6c299ee2e 100644
--- a/spec/features/projects/blobs/edit_spec.rb
+++ b/spec/features/projects/blobs/edit_spec.rb
@@ -81,17 +81,6 @@ describe 'Editing file blob', :js do
         expect(page).to have_content("sublist")
         expect(page).not_to have_xpath("//ol//li//ul")
       end
-
-      it 'renders content with RedCarpet when legacy_render is set' do
-        visit project_edit_blob_path(project, tree_join(branch, readme_file_path), legacy_render: 1)
-        fill_editor(content: "1. one\\n  - sublist\\n")
-        click_link 'Preview'
-        wait_for_requests
-
-        # the above generates a sublist list in RedCarpet
-        expect(page).to have_content("sublist")
-        expect(page).to have_xpath("//ol//li//ul")
-      end
     end
   end
 
diff --git a/spec/features/projects/wiki/markdown_preview_spec.rb b/spec/features/projects/wiki/markdown_preview_spec.rb
index f505023d1d0..3b469fee867 100644
--- a/spec/features/projects/wiki/markdown_preview_spec.rb
+++ b/spec/features/projects/wiki/markdown_preview_spec.rb
@@ -175,20 +175,6 @@ describe 'Projects > Wiki > User previews markdown changes', :js do
         expect(page).to have_content("sublist")
         expect(page).not_to have_xpath("//ol//li//ul")
       end
-
-      it 'renders content with RedCarpet when legacy_render is set' do
-        wiki_page = create(:wiki_page,
-                           wiki: project.wiki,
-                           attrs: { title: 'home', content: "Empty content" })
-        visit(project_wiki_edit_path(project, wiki_page, legacy_render: 1))
-
-        fill_in :wiki_content, with: "1. one\n  - sublist\n"
-        click_on "Preview"
-
-        # the above generates a sublist list in RedCarpet
-        expect(page).to have_content("sublist")
-        expect(page).to have_xpath("//ol//li//ul")
-      end
     end
   end
 
diff --git a/spec/features/snippets/show_spec.rb b/spec/features/snippets/show_spec.rb
index 367a479f62a..eb974c7c7fd 100644
--- a/spec/features/snippets/show_spec.rb
+++ b/spec/features/snippets/show_spec.rb
@@ -80,19 +80,6 @@ describe 'Snippet', :js do
           end
         end
 
-        context 'when rendering legacy markdown' do
-          before do
-            visit snippet_path(snippet, legacy_render: 1)
-
-            wait_for_requests
-          end
-
-          it 'renders using RedCarpet' do
-            expect(page).to have_content("sublist")
-            expect(page).to have_xpath("//ol//li//ul")
-          end
-        end
-
         context 'with cached CommonMark html' do
           let(:snippet) { create(:personal_snippet, :public, file_name: file_name, content: content, cached_markdown_version: CacheMarkdownField::CACHE_COMMONMARK_VERSION) }
 
@@ -100,14 +87,6 @@ describe 'Snippet', :js do
             expect(page).not_to have_xpath("//ol//li//ul")
           end
         end
-
-        context 'with cached Redcarpet html' do
-          let(:snippet) { create(:personal_snippet, :public, file_name: file_name, content: content, cached_markdown_version: CacheMarkdownField::CACHE_REDCARPET_VERSION) }
-
-          it 'renders correctly' do
-            expect(page).to have_xpath("//ol//li//ul")
-          end
-        end
       end
 
       context 'switching to the simple viewer' do
diff --git a/spec/features/task_lists_spec.rb b/spec/features/task_lists_spec.rb
index b549f2b5c62..6fe840dccf6 100644
--- a/spec/features/task_lists_spec.rb
+++ b/spec/features/task_lists_spec.rb
@@ -36,19 +36,6 @@ describe 'Task Lists' do
     MARKDOWN
   end
 
-  let(:nested_tasks_markdown_redcarpet) do
-    <<-EOT.strip_heredoc
-    - [ ] Task a
-      - [x] Task a.1
-      - [ ] Task a.2
-    - [ ] Task b
-
-    1. [ ] Task 1
-      1. [ ] Task 1.1
-      1. [x] Task 1.2
-    EOT
-  end
-
   let(:nested_tasks_markdown) do
     <<-EOT.strip_heredoc
     - [ ] Task a
@@ -153,61 +140,6 @@ describe 'Task Lists' do
         expect(page).to have_content("1 of 1 task completed")
       end
     end
-
-    shared_examples 'shared nested tasks' do
-      before do
-        allow(Banzai::Filter::MarkdownFilter).to receive(:engine).and_return('Redcarpet')
-        visit_issue(project, issue)
-      end
-      it 'renders' do
-        expect(page).to have_selector('ul.task-list',      count: 2)
-        expect(page).to have_selector('li.task-list-item', count: 7)
-        expect(page).to have_selector('ul input[checked]', count: 1)
-        expect(page).to have_selector('ol input[checked]', count: 1)
-      end
-
-      it 'solves tasks' do
-        expect(page).to have_content("2 of 7 tasks completed")
-
-        page.find('li.task-list-item', text: 'Task b').find('input').click
-        wait_for_requests
-        page.find('li.task-list-item ul li.task-list-item', text: 'Task a.2').find('input').click
-        wait_for_requests
-        page.find('li.task-list-item ol li.task-list-item', text: 'Task 1.1').find('input').click
-        wait_for_requests
-
-        expect(page).to have_content("5 of 7 tasks completed")
-
-        visit_issue(project, issue) # reload to see new system notes
-
-        expect(page).to have_content('marked the task Task b as complete')
-        expect(page).to have_content('marked the task Task a.2 as complete')
-        expect(page).to have_content('marked the task Task 1.1 as complete')
-      end
-    end
-
-    describe 'nested tasks', :js do
-      let(:cache_version) { CacheMarkdownField::CACHE_COMMONMARK_VERSION }
-      let!(:issue) do
-        create(:issue, description: nested_tasks_markdown, author: user, project: project,
-                       cached_markdown_version: cache_version)
-      end
-
-      before do
-        visit_issue(project, issue)
-      end
-
-      context 'with Redcarpet' do
-        let(:cache_version) { CacheMarkdownField::CACHE_REDCARPET_VERSION }
-        let(:nested_tasks_markdown) { nested_tasks_markdown_redcarpet }
-
-        it_behaves_like 'shared nested tasks'
-      end
-
-      context 'with CommonMark' do
-        it_behaves_like 'shared nested tasks'
-      end
-    end
   end
 
   describe 'for Notes' do
diff --git a/spec/fixtures/markdown.md.erb b/spec/fixtures/markdown.md.erb
index e5d01c3bd03..bbeacf1707b 100644
--- a/spec/fixtures/markdown.md.erb
+++ b/spec/fixtures/markdown.md.erb
@@ -6,7 +6,7 @@ started.
 
 ## Markdown
 
-GitLab uses [Redcarpet](http://git.io/ld_NVQ) to parse all Markdown into
+GitLab uses [Commonmark](https://git.io/fhDag) to parse all Markdown into
 HTML.
 
 It has some special features. Let's try 'em out!
diff --git a/spec/helpers/issuables_helper_spec.rb b/spec/helpers/issuables_helper_spec.rb
index af319e5ebfe..8b82dea2524 100644
--- a/spec/helpers/issuables_helper_spec.rb
+++ b/spec/helpers/issuables_helper_spec.rb
@@ -188,7 +188,6 @@ describe IssuablesHelper do
         issuableRef: "##{issue.iid}",
         markdownPreviewPath: "/#{@project.full_path}/preview_markdown",
         markdownDocsPath: '/help/user/markdown',
-        markdownVersion: CacheMarkdownField::CACHE_COMMONMARK_VERSION,
         issuableTemplates: [],
         lockVersion: issue.lock_version,
         projectPath: @project.path,
diff --git a/spec/helpers/markup_helper_spec.rb b/spec/helpers/markup_helper_spec.rb
index a0c0af94fa5..c3956ba08fd 100644
--- a/spec/helpers/markup_helper_spec.rb
+++ b/spec/helpers/markup_helper_spec.rb
@@ -212,17 +212,6 @@ describe MarkupHelper do
       helper.render_wiki_content(@wiki)
     end
 
-    it 'uses Wiki pipeline for markdown files with RedCarpet if feature disabled' do
-      stub_feature_flags(commonmark_for_repositories: false)
-      allow(@wiki).to receive(:format).and_return(:markdown)
-
-      expect(helper).to receive(:markdown_unsafe).with('wiki content',
-        pipeline: :wiki, project: project, project_wiki: @wiki, page_slug: "nested/page",
-        issuable_state_filter_enabled: true, markdown_engine: :redcarpet)
-
-      helper.render_wiki_content(@wiki)
-    end
-
     it "uses Asciidoctor for asciidoc files" do
       allow(@wiki).to receive(:format).and_return(:asciidoc)
 
@@ -273,16 +262,6 @@ describe MarkupHelper do
     it 'defaults to CommonMark' do
       expect(helper.markup('foo.md', 'x^2')).to include('x^2')
     end
-
-    it 'honors markdown_engine for RedCarpet' do
-      expect(helper.markup('foo.md', 'x^2', { markdown_engine: :redcarpet })).to include('x<sup>2</sup>')
-    end
-
-    it 'uses RedCarpet if feature disabled' do
-      stub_feature_flags(commonmark_for_repositories: false)
-
-      expect(helper.markup('foo.md', 'x^2', { markdown_engine: :redcarpet })).to include('x<sup>2</sup>')
-    end
   end
 
   describe '#first_line_in_markdown' do
diff --git a/spec/helpers/projects_helper_spec.rb b/spec/helpers/projects_helper_spec.rb
index 10f61731206..098ccc1b5be 100644
--- a/spec/helpers/projects_helper_spec.rb
+++ b/spec/helpers/projects_helper_spec.rb
@@ -540,18 +540,6 @@ describe ProjectsHelper do
     end
   end
 
-  describe '#legacy_render_context' do
-    it 'returns the redcarpet engine' do
-      params = { legacy_render: '1' }
-
-      expect(helper.legacy_render_context(params)).to include(markdown_engine: :redcarpet)
-    end
-
-    it 'returns nothing' do
-      expect(helper.legacy_render_context({})).to be_empty
-    end
-  end
-
   describe '#explore_projects_tab?' do
     subject { helper.explore_projects_tab? }
 
diff --git a/spec/lib/banzai/filter/markdown_filter_spec.rb b/spec/lib/banzai/filter/markdown_filter_spec.rb
index 4c4e821deab..83fcda29680 100644
--- a/spec/lib/banzai/filter/markdown_filter_spec.rb
+++ b/spec/lib/banzai/filter/markdown_filter_spec.rb
@@ -10,12 +10,6 @@ describe Banzai::Filter::MarkdownFilter do
       filter('test')
     end
 
-    it 'uses Redcarpet' do
-      expect_any_instance_of(Banzai::Filter::MarkdownEngines::Redcarpet).to receive(:render).and_return('test')
-
-      filter('test', { markdown_engine: :redcarpet })
-    end
-
     it 'uses CommonMark' do
       expect_any_instance_of(Banzai::Filter::MarkdownEngines::CommonMark).to receive(:render).and_return('test')
 
@@ -47,24 +41,6 @@ describe Banzai::Filter::MarkdownFilter do
         expect(result).to start_with('<pre><code lang="日">')
       end
     end
-
-    context 'using Redcarpet' do
-      before do
-        stub_const('Banzai::Filter::MarkdownFilter::DEFAULT_ENGINE', :redcarpet)
-      end
-
-      it 'adds language to lang attribute when specified' do
-        result = filter("```html\nsome code\n```")
-
-        expect(result).to start_with("\n<pre><code lang=\"html\">")
-      end
-
-      it 'does not add language to lang attribute when not specified' do
-        result = filter("```\nsome code\n```")
-
-        expect(result).to start_with("\n<pre><code>")
-      end
-    end
   end
 
   describe 'source line position' do
@@ -85,18 +61,6 @@ describe Banzai::Filter::MarkdownFilter do
         expect(result).to eq '<p>test</p>'
       end
     end
-
-    context 'using Redcarpet' do
-      before do
-        stub_const('Banzai::Filter::MarkdownFilter::DEFAULT_ENGINE', :redcarpet)
-      end
-
-      it 'does not support data-sourcepos' do
-        result = filter('test')
-
-        expect(result).to eq '<p>test</p>'
-      end
-    end
   end
 
   describe 'footnotes in tables' do
diff --git a/spec/lib/banzai/filter/spaced_link_filter_spec.rb b/spec/lib/banzai/filter/spaced_link_filter_spec.rb
index 1ad7f3ff567..76d7644d76c 100644
--- a/spec/lib/banzai/filter/spaced_link_filter_spec.rb
+++ b/spec/lib/banzai/filter/spaced_link_filter_spec.rb
@@ -26,11 +26,6 @@ describe Banzai::Filter::SpacedLinkFilter do
       expect(doc.at_css('p')).to be_nil
     end
 
-    it 'does nothing when markdown_engine is redcarpet' do
-      exp = act = link
-      expect(filter(act, markdown_engine: :redcarpet).to_html).to eq exp
-    end
-
     it 'does nothing with empty text' do
       link = '[](page slug)'
       doc  = filter("See #{link}")
diff --git a/spec/models/concerns/cache_markdown_field_spec.rb b/spec/models/concerns/cache_markdown_field_spec.rb
index 925e2ab0955..29197ef372e 100644
--- a/spec/models/concerns/cache_markdown_field_spec.rb
+++ b/spec/models/concerns/cache_markdown_field_spec.rb
@@ -73,6 +73,7 @@ describe CacheMarkdownField do
   let(:updated_html)     { '<p dir="auto"><code>Bar</code></p>' }
 
   let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: CacheMarkdownField::CACHE_COMMONMARK_VERSION) }
+  let(:cache_version) { CacheMarkdownField::CACHE_COMMONMARK_VERSION }
 
   before do
     stub_commonmark_sourcepos_disabled
@@ -97,20 +98,15 @@ describe CacheMarkdownField do
   end
 
   context 'a changed markdown field' do
-    shared_examples 'with cache version' do |cache_version|
-      let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: cache_version) }
+    let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: cache_version) }
 
-      before do
-        thing.foo = updated_markdown
-        thing.save
-      end
-
-      it { expect(thing.foo_html).to eq(updated_html) }
-      it { expect(thing.cached_markdown_version).to eq(cache_version) }
+    before do
+      thing.foo = updated_markdown
+      thing.save
     end
 
-    it_behaves_like 'with cache version', CacheMarkdownField::CACHE_REDCARPET_VERSION
-    it_behaves_like 'with cache version', CacheMarkdownField::CACHE_COMMONMARK_VERSION
+    it { expect(thing.foo_html).to eq(updated_html) }
+    it { expect(thing.cached_markdown_version).to eq(cache_version) }
   end
 
   context 'when a markdown field is set repeatedly to an empty string' do
@@ -143,22 +139,17 @@ describe CacheMarkdownField do
   end
 
   context 'a non-markdown field changed' do
-    shared_examples 'with cache version' do |cache_version|
-      let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: cache_version) }
-
-      before do
-        thing.bar = 'OK'
-        thing.save
-      end
+    let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: cache_version) }
 
-      it { expect(thing.bar).to eq('OK') }
-      it { expect(thing.foo).to eq(markdown) }
-      it { expect(thing.foo_html).to eq(html) }
-      it { expect(thing.cached_markdown_version).to eq(cache_version) }
+    before do
+      thing.bar = 'OK'
+      thing.save
     end
 
-    it_behaves_like 'with cache version', CacheMarkdownField::CACHE_REDCARPET_VERSION
-    it_behaves_like 'with cache version', CacheMarkdownField::CACHE_COMMONMARK_VERSION
+    it { expect(thing.bar).to eq('OK') }
+    it { expect(thing.foo).to eq(markdown) }
+    it { expect(thing.foo_html).to eq(html) }
+    it { expect(thing.cached_markdown_version).to eq(cache_version) }
   end
 
   context 'version is out of date' do
@@ -173,73 +164,63 @@ describe CacheMarkdownField do
   end
 
   describe '#cached_html_up_to_date?' do
-    shared_examples 'with cache version' do |cache_version|
-      let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: cache_version) }
+    let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: cache_version) }
 
-      subject { thing.cached_html_up_to_date?(:foo) }
+    subject { thing.cached_html_up_to_date?(:foo) }
 
-      it 'returns false when the version is absent' do
-        thing.cached_markdown_version = nil
+    it 'returns false when the version is absent' do
+      thing.cached_markdown_version = nil
 
-        is_expected.to be_falsy
-      end
+      is_expected.to be_falsy
+    end
 
-      it 'returns false when the version is too early' do
-        thing.cached_markdown_version -= 1
+    it 'returns false when the version is too early' do
+      thing.cached_markdown_version -= 1
 
-        is_expected.to be_falsy
-      end
+      is_expected.to be_falsy
+    end
 
-      it 'returns false when the version is too late' do
-        thing.cached_markdown_version += 1
+    it 'returns false when the version is too late' do
+      thing.cached_markdown_version += 1
 
-        is_expected.to be_falsy
-      end
+      is_expected.to be_falsy
+    end
 
-      it 'returns true when the version is just right' do
-        thing.cached_markdown_version = cache_version
+    it 'returns true when the version is just right' do
+      thing.cached_markdown_version = cache_version
 
-        is_expected.to be_truthy
-      end
+      is_expected.to be_truthy
+    end
 
-      it 'returns false if markdown has been changed but html has not' do
-        thing.foo = updated_html
+    it 'returns false if markdown has been changed but html has not' do
+      thing.foo = updated_html
 
-        is_expected.to be_falsy
-      end
+      is_expected.to be_falsy
+    end
 
-      it 'returns true if markdown has not been changed but html has' do
-        thing.foo_html = updated_html
+    it 'returns true if markdown has not been changed but html has' do
+      thing.foo_html = updated_html
 
-        is_expected.to be_truthy
-      end
+      is_expected.to be_truthy
+    end
 
-      it 'returns true if markdown and html have both been changed' do
-        thing.foo = updated_markdown
-        thing.foo_html = updated_html
+    it 'returns true if markdown and html have both been changed' do
+      thing.foo = updated_markdown
+      thing.foo_html = updated_html
 
-        is_expected.to be_truthy
-      end
+      is_expected.to be_truthy
+    end
 
-      it 'returns false if the markdown field is set but the html is not' do
-        thing.foo_html = nil
+    it 'returns false if the markdown field is set but the html is not' do
+      thing.foo_html = nil
 
-        is_expected.to be_falsy
-      end
+      is_expected.to be_falsy
     end
-
-    it_behaves_like 'with cache version', CacheMarkdownField::CACHE_REDCARPET_VERSION
-    it_behaves_like 'with cache version', CacheMarkdownField::CACHE_COMMONMARK_VERSION
   end
 
   describe '#latest_cached_markdown_version' do
     subject { thing.latest_cached_markdown_version }
 
-    it 'returns redcarpet version' do
-      thing.cached_markdown_version = CacheMarkdownField::CACHE_COMMONMARK_VERSION_START - 1
-      is_expected.to eq(CacheMarkdownField::CACHE_REDCARPET_VERSION)
-    end
-
     it 'returns commonmark version' do
       thing.cached_markdown_version = CacheMarkdownField::CACHE_COMMONMARK_VERSION_START + 1
       is_expected.to eq(CacheMarkdownField::CACHE_COMMONMARK_VERSION)
@@ -251,30 +232,6 @@ describe CacheMarkdownField do
     end
   end
 
-  describe '#legacy_markdown?' do
-    subject { thing.legacy_markdown? }
-
-    it 'returns true for redcarpet versions' do
-      thing.cached_markdown_version = CacheMarkdownField::CACHE_COMMONMARK_VERSION_START - 1
-      is_expected.to be_truthy
-    end
-
-    it 'returns false for commonmark versions' do
-      thing.cached_markdown_version = CacheMarkdownField::CACHE_COMMONMARK_VERSION_START
-      is_expected.to be_falsey
-    end
-
-    it 'returns false if nil' do
-      thing.cached_markdown_version = nil
-      is_expected.to be_falsey
-    end
-
-    it 'returns false if 0' do
-      thing.cached_markdown_version = 0
-      is_expected.to be_falsey
-    end
-  end
-
   describe '#refresh_markdown_cache' do
     before do
       thing.foo = updated_markdown
@@ -303,39 +260,34 @@ describe CacheMarkdownField do
   end
 
   describe '#refresh_markdown_cache!' do
-    shared_examples 'with cache version' do |cache_version|
-      let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: cache_version) }
+    let(:thing) { ThingWithMarkdownFields.new(foo: markdown, foo_html: html, cached_markdown_version: cache_version) }
 
-      before do
-        thing.foo = updated_markdown
-      end
+    before do
+      thing.foo = updated_markdown
+    end
 
-      it 'fills all html fields' do
-        thing.refresh_markdown_cache!
+    it 'fills all html fields' do
+      thing.refresh_markdown_cache!
 
-        expect(thing.foo_html).to eq(updated_html)
-        expect(thing.foo_html_changed?).to be_truthy
-        expect(thing.baz_html_changed?).to be_truthy
-      end
+      expect(thing.foo_html).to eq(updated_html)
+      expect(thing.foo_html_changed?).to be_truthy
+      expect(thing.baz_html_changed?).to be_truthy
+    end
 
-      it 'skips saving if not persisted' do
-        expect(thing).to receive(:persisted?).and_return(false)
-        expect(thing).not_to receive(:update_columns)
+    it 'skips saving if not persisted' do
+      expect(thing).to receive(:persisted?).and_return(false)
+      expect(thing).not_to receive(:update_columns)
 
-        thing.refresh_markdown_cache!
-      end
+      thing.refresh_markdown_cache!
+    end
 
-      it 'saves the changes using #update_columns' do
-        expect(thing).to receive(:persisted?).and_return(true)
-        expect(thing).to receive(:update_columns)
-          .with("foo_html" => updated_html, "baz_html" => "", "cached_markdown_version" => cache_version)
+    it 'saves the changes using #update_columns' do
+      expect(thing).to receive(:persisted?).and_return(true)
+      expect(thing).to receive(:update_columns)
+        .with("foo_html" => updated_html, "baz_html" => "", "cached_markdown_version" => cache_version)
 
-        thing.refresh_markdown_cache!
-      end
+      thing.refresh_markdown_cache!
     end
-
-    it_behaves_like 'with cache version', CacheMarkdownField::CACHE_REDCARPET_VERSION
-    it_behaves_like 'with cache version', CacheMarkdownField::CACHE_COMMONMARK_VERSION
   end
 
   describe '#banzai_render_context' do
@@ -408,20 +360,4 @@ describe CacheMarkdownField do
       end
     end
   end
-
-  describe CacheMarkdownField::MarkdownEngine do
-    subject { lambda { |version| CacheMarkdownField::MarkdownEngine.from_version(version) } }
-
-    it 'returns :common_mark as a default' do
-      expect(subject.call(nil)).to eq :common_mark
-    end
-
-    it 'returns :common_mark' do
-      expect(subject.call(CacheMarkdownField::CACHE_COMMONMARK_VERSION)).to eq :common_mark
-    end
-
-    it 'returns :redcarpet' do
-      expect(subject.call(CacheMarkdownField::CACHE_REDCARPET_VERSION)).to eq :redcarpet
-    end
-  end
 end
diff --git a/spec/services/preview_markdown_service_spec.rb b/spec/services/preview_markdown_service_spec.rb
index 458cb8f1f31..85515d548a7 100644
--- a/spec/services/preview_markdown_service_spec.rb
+++ b/spec/services/preview_markdown_service_spec.rb
@@ -114,23 +114,4 @@ describe PreviewMarkdownService do
       expect(result[:commands]).to eq 'Tags this commit to v1.2.3 with "Stable release".'
     end
   end
-
-  it 'sets correct markdown engine' do
-    service = described_class.new(project, user, { markdown_version: CacheMarkdownField::CACHE_REDCARPET_VERSION })
-    result  = service.execute
-
-    expect(result[:markdown_engine]).to eq :redcarpet
-
-    service = described_class.new(project, user, { markdown_version: CacheMarkdownField::CACHE_COMMONMARK_VERSION })
-    result  = service.execute
-
-    expect(result[:markdown_engine]).to eq :common_mark
-  end
-
-  it 'honors the legacy_render parameter' do
-    service = described_class.new(project, user, { legacy_render: '1' })
-    result  = service.execute
-
-    expect(result[:markdown_engine]).to eq :redcarpet
-  end
 end
diff --git a/spec/services/task_list_toggle_service_spec.rb b/spec/services/task_list_toggle_service_spec.rb
index 750ac4c40ba..cc64dd25085 100644
--- a/spec/services/task_list_toggle_service_spec.rb
+++ b/spec/services/task_list_toggle_service_spec.rb
@@ -3,7 +3,6 @@
 require 'spec_helper'
 
 describe TaskListToggleService do
-  let(:sourcepos) { true }
   let(:markdown) do
     <<-EOT.strip_heredoc
       * [ ] Task 1
@@ -40,87 +39,47 @@ describe TaskListToggleService do
     EOT
   end
 
-  shared_examples 'task lists' do
-    it 'checks Task 1' do
-      toggler = described_class.new(markdown, markdown_html,
-                                    index: 1, toggle_as_checked: true,
-                                    line_source: '* [ ] Task 1', line_number: 1,
-                                    sourcepos: sourcepos)
+  it 'checks Task 1' do
+    toggler = described_class.new(markdown, markdown_html,
+                                  toggle_as_checked: true,
+                                  line_source: '* [ ] Task 1', line_number: 1)
 
-      expect(toggler.execute).to be_truthy
-      expect(toggler.updated_markdown.lines[0]).to eq "* [x] Task 1\n"
-      expect(toggler.updated_markdown_html).to include('disabled checked> Task 1')
-    end
-
-    it 'unchecks Item 1' do
-      toggler = described_class.new(markdown, markdown_html,
-                                    index: 3, toggle_as_checked: false,
-                                    line_source: '1. [X] Item 1', line_number: 6,
-                                    sourcepos: sourcepos)
-
-      expect(toggler.execute).to be_truthy
-      expect(toggler.updated_markdown.lines[5]).to eq "1. [ ] Item 1\n"
-      expect(toggler.updated_markdown_html).to include('disabled> Item 1')
-    end
-
-    it 'returns false if line_source does not match the text' do
-      toggler = described_class.new(markdown, markdown_html,
-                                    index: 2, toggle_as_checked: false,
-                                    line_source: '* [x] Task Added', line_number: 2,
-                                    sourcepos: sourcepos)
-
-      expect(toggler.execute).to be_falsey
-    end
+    expect(toggler.execute).to be_truthy
+    expect(toggler.updated_markdown.lines[0]).to eq "* [x] Task 1\n"
+    expect(toggler.updated_markdown_html).to include('disabled checked> Task 1')
+  end
 
-    it 'returns false if markdown is nil' do
-      toggler = described_class.new(nil, markdown_html,
-                                    index: 2, toggle_as_checked: false,
-                                    line_source: '* [x] Task Added', line_number: 2,
-                                    sourcepos: sourcepos)
+  it 'unchecks Item 1' do
+    toggler = described_class.new(markdown, markdown_html,
+                                  toggle_as_checked: false,
+                                  line_source: '1. [X] Item 1', line_number: 6)
 
-      expect(toggler.execute).to be_falsey
-    end
+    expect(toggler.execute).to be_truthy
+    expect(toggler.updated_markdown.lines[5]).to eq "1. [ ] Item 1\n"
+    expect(toggler.updated_markdown_html).to include('disabled> Item 1')
+  end
 
-    it 'returns false if markdown_html is nil' do
-      toggler = described_class.new(markdown, nil,
-                                    index: 2, toggle_as_checked: false,
-                                    line_source: '* [x] Task Added', line_number: 2,
-                                    sourcepos: sourcepos)
+  it 'returns false if line_source does not match the text' do
+    toggler = described_class.new(markdown, markdown_html,
+                                  toggle_as_checked: false,
+                                  line_source: '* [x] Task Added', line_number: 2)
 
-      expect(toggler.execute).to be_falsey
-    end
+    expect(toggler.execute).to be_falsey
   end
 
-  context 'when using sourcepos' do
-    it_behaves_like 'task lists'
+  it 'returns false if markdown is nil' do
+    toggler = described_class.new(nil, markdown_html,
+                                  toggle_as_checked: false,
+                                  line_source: '* [x] Task Added', line_number: 2)
+
+    expect(toggler.execute).to be_falsey
   end
 
-  context 'when using checkbox indexing' do
-    let(:sourcepos) { false }
-    let(:markdown_html) do
-      <<-EOT.strip_heredoc
-      <ul class="task-list" dir="auto">
-        <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" disabled> Task 1
-        </li>
-        <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" disabled checked> Task 2
-        </li>
-      </ul>
-      <p dir="auto">A paragraph</p>
-      <ol class="task-list" dir="auto">
-        <li class="task-list-item">
-          <input type="checkbox" class="task-list-item-checkbox" disabled checked> Item 1
-          <ul class="task-list">
-            <li class="task-list-item">
-              <input type="checkbox" class="task-list-item-checkbox" disabled> Sub-item 1
-            </li>
-          </ul>
-        </li>
-      </ol>
-      EOT
-    end
+  it 'returns false if markdown_html is nil' do
+    toggler = described_class.new(markdown, nil,
+                                  toggle_as_checked: false,
+                                  line_source: '* [x] Task Added', line_number: 2)
 
-    it_behaves_like 'task lists'
+    expect(toggler.execute).to be_falsey
   end
 end