Also warn on timestamp in datetime migration copfix-timestampz-cop

The types `timestamp` and `datetime` are aliases:
https://github.com/rails/rails/blob/v4.2.10/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb#L362-L364

1 files changed, 26 insertions, 0 deletions

diff --git a/spec/rubocop/cop/migration/datetime_spec.rb b/spec/rubocop/cop/migration/datetime_spec.rb
index 388b086ce6a..b1dfcf1b048 100644
--- a/spec/rubocop/cop/migration/datetime_spec.rb
+++ b/spec/rubocop/cop/migration/datetime_spec.rb
@@ -9,6 +9,7 @@ describe RuboCop::Cop::Migration::Datetime do
   include CopHelper
 
   subject(:cop) { described_class.new }
+
   let(:migration_with_datetime) do
     %q(
       class Users < ActiveRecord::Migration
@@ -22,6 +23,19 @@ describe RuboCop::Cop::Migration::Datetime do
     )
   end
 
+  let(:migration_with_timestamp) do
+    %q(
+      class Users < ActiveRecord::Migration
+        DOWNTIME = false
+
+        def change
+          add_column(:users, :username, :text)
+          add_column(:users, :last_sign_in, :timestamp)
+        end
+      end
+    )
+  end
+
   let(:migration_without_datetime) do
     %q(
       class Users < ActiveRecord::Migration
@@ -58,6 +72,17 @@ describe RuboCop::Cop::Migration::Datetime do
       aggregate_failures do
         expect(cop.offenses.size).to eq(1)
         expect(cop.offenses.map(&:line)).to eq([7])
+        expect(cop.offenses.first.message).to include('datetime')
+      end
+    end
+
+    it 'registers an offense when the ":timestamp" data type is used' do
+      inspect_source(cop, migration_with_timestamp)
+
+      aggregate_failures do
+        expect(cop.offenses.size).to eq(1)
+        expect(cop.offenses.map(&:line)).to eq([7])
+        expect(cop.offenses.first.message).to include('timestamp')
       end
     end
 
@@ -81,6 +106,7 @@ describe RuboCop::Cop::Migration::Datetime do
   context 'outside of migration' do
     it 'registers no offense' do
       inspect_source(cop, migration_with_datetime)
+      inspect_source(cop, migration_with_timestamp)
       inspect_source(cop, migration_without_datetime)
       inspect_source(cop, migration_with_datetime_with_timezone)