diff options
author | Sean McGivern <sean@mcgivern.me.uk> | 2017-04-24 18:09:22 +0000 |
---|---|---|
committer | Sean McGivern <sean@mcgivern.me.uk> | 2017-04-24 18:09:22 +0000 |
commit | 3ac4ef221b532e3425d890f044ef7d39ac81e163 (patch) | |
tree | 6a3bf471ab4b7c0fc5b6c4a998ac57bb7e8a7719 /spec | |
parent | ce559142a64890aa18f6669bc5386509efdd4ac9 (diff) | |
parent | 68bb2a53383d79e5e3e38f9894f0ea61c3701f46 (diff) | |
download | gitlab-ce-3ac4ef221b532e3425d890f044ef7d39ac81e163.tar.gz |
Merge branch 'sh-optimize-milestone-polymorphic-url' into 'master'
Eliminate N+1 queries in loading namespaces for every issuable in milestones
See merge request !10871
Diffstat (limited to 'spec')
-rw-r--r-- | spec/controllers/projects/milestones_controller_spec.rb | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/spec/controllers/projects/milestones_controller_spec.rb b/spec/controllers/projects/milestones_controller_spec.rb index 14207bf6b7a..47e61c3cea8 100644 --- a/spec/controllers/projects/milestones_controller_spec.rb +++ b/spec/controllers/projects/milestones_controller_spec.rb @@ -5,6 +5,7 @@ describe Projects::MilestonesController do let(:user) { create(:user) } let(:milestone) { create(:milestone, project: project) } let(:issue) { create(:issue, project: project, milestone: milestone) } + let!(:label) { create(:label, project: project, title: 'Issue Label', issues: [issue]) } let!(:merge_request) { create(:merge_request, source_project: project, target_project: project, milestone: milestone) } before do @@ -13,6 +14,20 @@ describe Projects::MilestonesController do controller.instance_variable_set(:@project, project) end + describe "#show" do + render_views + + def view_milestone + get :show, namespace_id: project.namespace.id, project_id: project.id, id: milestone.iid + end + + it 'shows milestone page' do + view_milestone + + expect(response).to have_http_status(200) + end + end + describe "#destroy" do it "removes milestone" do expect(issue.milestone_id).to eq(milestone.id) |