diff options
author | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-10-19 17:50:41 +0300 |
---|---|---|
committer | Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | 2016-10-24 13:14:00 +0300 |
commit | 1eba14ae2ecd829642e88610b0b2964e5d04158e (patch) | |
tree | 07130fb3835cff9fe149957351d0d5493bd6cea8 /spec | |
parent | c82278898d4e7932da1e0071d4dcfa13f65967f0 (diff) | |
download | gitlab-ce-1eba14ae2ecd829642e88610b0b2964e5d04158e.tar.gz |
Refactor create member tests from group_members_controller_spec
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Diffstat (limited to 'spec')
-rw-r--r-- | spec/controllers/groups/group_members_controller_spec.rb | 71 |
1 files changed, 30 insertions, 41 deletions
diff --git a/spec/controllers/groups/group_members_controller_spec.rb b/spec/controllers/groups/group_members_controller_spec.rb index 82eebe6f2d4..c7db84dd5f9 100644 --- a/spec/controllers/groups/group_members_controller_spec.rb +++ b/spec/controllers/groups/group_members_controller_spec.rb @@ -13,56 +13,45 @@ describe Groups::GroupMembersController do end end - describe '#create' do - let(:group) { create(:group, :public) } - - context 'when users are added' do - let(:user) { create(:user) } - let(:group_user) { create(:user) } - let(:member) do - group.add_developer(group_user) - group.members.find_by(user_id: group_user) - end + describe 'POST create' do + let(:group_user) { create(:user) } - context 'when user does not have enough rights' do - before do - group.members.delete(member) - group.add_developer(user) - sign_in(user) - end + before { sign_in(user) } - it 'returns 403' do - post :create, group_id: group, - user_ids: member + context 'when user does not have enough rights' do + before { group.add_developer(user) } - expect(response).to have_http_status(403) - expect(group.users).not_to include group_user - end + it 'returns 403' do + post :create, group_id: group, + user_ids: group_user.id, + access_level: Gitlab::Access::GUEST + + expect(response).to have_http_status(403) + expect(group.users).not_to include group_user end + end - context 'when user has enough rights' do - before do - group.add_owner(user) - sign_in(user) - end + context 'when user has enough rights' do + before { group.add_owner(user) } - it 'adds user to members' do - post :create, group_id: group, - user_ids: member + it 'adds user to members' do + post :create, group_id: group, + user_ids: group_user.id, + access_level: Gitlab::Access::GUEST - expect(response).to set_flash.to 'Users were successfully added.' - expect(response).to redirect_to(group_group_members_path(group)) - expect(group.users).to include group_user - end + expect(response).to set_flash.to 'Users were successfully added.' + expect(response).to redirect_to(group_group_members_path(group)) + expect(group.users).to include group_user + end - it 'adds no user to members' do - post :create, group_id: group, - user_ids: '' + it 'adds no user to members' do + post :create, group_id: group, + user_ids: '', + access_level: Gitlab::Access::GUEST - expect(response).to set_flash.to 'No users specified.' - expect(response).to redirect_to(group_group_members_path(group)) - expect(group.users).not_to include group_user - end + expect(response).to set_flash.to 'No users specified.' + expect(response).to redirect_to(group_group_members_path(group)) + expect(group.users).not_to include group_user end end end |