summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorFabio Papa <fabtheman@gmail.com>2019-06-16 11:07:17 -0700
committerFabio Papa <fabtheman@gmail.com>2019-07-02 11:36:00 -0700
commit6d50040c9469d2b1b6c137897b5d7403f3e3b7d5 (patch)
tree493875823c10e4964b1d86e89871e02e31956030 /spec
parent467ed9d4e79b27557f6407ed4fd567473b83ab76 (diff)
downloadgitlab-ce-6d50040c9469d2b1b6c137897b5d7403f3e3b7d5.tar.gz
Add failing unit test specifying a maintainer creating a subgroup
Diffstat (limited to 'spec')
-rw-r--r--spec/services/groups/create_service_spec.rb9
-rw-r--r--spec/support/shared_contexts/policies/group_policy_shared_context.rb12
2 files changed, 19 insertions, 2 deletions
diff --git a/spec/services/groups/create_service_spec.rb b/spec/services/groups/create_service_spec.rb
index c5ff6cdbacd..b4e6ddddfac 100644
--- a/spec/services/groups/create_service_spec.rb
+++ b/spec/services/groups/create_service_spec.rb
@@ -1,3 +1,4 @@
+# coding: utf-8
# frozen_string_literal: true
require 'spec_helper'
@@ -87,6 +88,14 @@ describe Groups::CreateService, '#execute' do
it { is_expected.to be_persisted }
end
+
+ context 'as maintainer' do
+ before do
+ group.add_maintainer(user)
+ end
+
+ it { is_expected.to be_persisted }
+ end
end
end
diff --git a/spec/support/shared_contexts/policies/group_policy_shared_context.rb b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
index b4808ac0068..b4b09d3295f 100644
--- a/spec/support/shared_contexts/policies/group_policy_shared_context.rb
+++ b/spec/support/shared_contexts/policies/group_policy_shared_context.rb
@@ -23,6 +23,15 @@ RSpec.shared_context 'GroupPolicy context' do
create_projects
read_cluster create_cluster update_cluster admin_cluster add_cluster
]
+ [
+ :create_projects,
+ :read_cluster,
+ :create_cluster,
+ :update_cluster,
+ :admin_cluster,
+ :add_cluster,
+ (Gitlab::Database.postgresql? ? :create_subgroup : nil)
+ ].compact
end
let(:owner_permissions) do
[
@@ -30,8 +39,7 @@ RSpec.shared_context 'GroupPolicy context' do
:admin_namespace,
:admin_group_member,
:change_visibility_level,
- :set_note_created_at,
- (Gitlab::Database.postgresql? ? :create_subgroup : nil)
+ :set_note_created_at
].compact
end