diff options
author | Sean McGivern <sean@mcgivern.me.uk> | 2016-12-09 13:28:42 +0000 |
---|---|---|
committer | Sean McGivern <sean@mcgivern.me.uk> | 2016-12-09 13:28:42 +0000 |
commit | b026e8cd88a3345c8c8fdb25bb12465d520939f6 (patch) | |
tree | 56f2bb1d8bf9800161fa6e4e037ef3aa813f38d4 /spec | |
parent | 1f9d688ffcc091d2b7167e6e51a070c1271823ce (diff) | |
parent | 4af62042bb7ddeff742a62048438673811e5344a (diff) | |
download | gitlab-ce-b026e8cd88a3345c8c8fdb25bb12465d520939f6.tar.gz |
Merge branch '25272_fix_comments_tab_disappearing' into 'master'
Fix comments tab disappearing
Fixes #25272
See merge request !7913
Diffstat (limited to 'spec')
-rw-r--r-- | spec/features/projects/features_visibility_spec.rb | 38 |
1 files changed, 38 insertions, 0 deletions
diff --git a/spec/features/projects/features_visibility_spec.rb b/spec/features/projects/features_visibility_spec.rb index 09aa6758b5c..3bb33394be7 100644 --- a/spec/features/projects/features_visibility_spec.rb +++ b/spec/features/projects/features_visibility_spec.rb @@ -182,6 +182,44 @@ describe 'Edit Project Settings', feature: true do expect(page).not_to have_content("Comments") end end + + # Regression spec for https://gitlab.com/gitlab-org/gitlab-ce/issues/25272 + it "hides comments activity tab only on disabled issues, merge requests and repository" do + select "Disabled", from: "project_project_feature_attributes_issues_access_level" + + save_changes_and_check_activity_tab do + expect(page).to have_content("Comments") + end + + visit edit_namespace_project_path(project.namespace, project) + + select "Disabled", from: "project_project_feature_attributes_merge_requests_access_level" + + save_changes_and_check_activity_tab do + expect(page).to have_content("Comments") + end + + visit edit_namespace_project_path(project.namespace, project) + + select "Disabled", from: "project_project_feature_attributes_repository_access_level" + + save_changes_and_check_activity_tab do + expect(page).not_to have_content("Comments") + end + + visit edit_namespace_project_path(project.namespace, project) + end + + def save_changes_and_check_activity_tab + click_button "Save changes" + wait_for_ajax + + visit activity_namespace_project_path(project.namespace, project) + + page.within(".event-filter") do + yield + end + end end # Regression spec for https://gitlab.com/gitlab-org/gitlab-ce/issues/24056 |