diff options
author | Felipe Artur <felipefac@gmail.com> | 2016-12-21 16:36:24 -0200 |
---|---|---|
committer | Felipe Artur <felipefac@gmail.com> | 2016-12-29 16:52:04 -0200 |
commit | f9963fe029122c9d7e866368b1fc1218e071f9d6 (patch) | |
tree | 7b2cabd842221156a9c947c693ee6b53c6616c88 /spec | |
parent | 7e88b242ce194958c6a59755eb434c17625c4395 (diff) | |
download | gitlab-ce-f9963fe029122c9d7e866368b1fc1218e071f9d6.tar.gz |
Parse JIRA issue references even if Issue Tracker is disabled
Diffstat (limited to 'spec')
-rw-r--r-- | spec/features/projects/features_visibility_spec.rb | 11 | ||||
-rw-r--r-- | spec/lib/banzai/reference_parser/external_issue_parser_spec.rb | 12 |
2 files changed, 22 insertions, 1 deletions
diff --git a/spec/features/projects/features_visibility_spec.rb b/spec/features/projects/features_visibility_spec.rb index 3bb33394be7..9079350186d 100644 --- a/spec/features/projects/features_visibility_spec.rb +++ b/spec/features/projects/features_visibility_spec.rb @@ -42,6 +42,17 @@ describe 'Edit Project Settings', feature: true do end end + context "When external issue tracker is enabled" do + it "does not hide issues tab" do + project.project_feature.update(issues_access_level: ProjectFeature::DISABLED) + allow_any_instance_of(Project).to receive(:external_issue_tracker).and_return(JiraService.new) + + visit namespace_project_path(project.namespace, project) + + expect(page).to have_selector(".shortcuts-issues") + end + end + context "pipelines subtabs" do it "shows builds when enabled" do visit namespace_project_pipelines_path(project.namespace, project) diff --git a/spec/lib/banzai/reference_parser/external_issue_parser_spec.rb b/spec/lib/banzai/reference_parser/external_issue_parser_spec.rb index 50a5d1a19ba..0af36776a54 100644 --- a/spec/lib/banzai/reference_parser/external_issue_parser_spec.rb +++ b/spec/lib/banzai/reference_parser/external_issue_parser_spec.rb @@ -12,7 +12,17 @@ describe Banzai::ReferenceParser::ExternalIssueParser, lib: true do context 'when the link has a data-issue attribute' do before { link['data-external-issue'] = 123 } - it_behaves_like "referenced feature visibility", "issues" + levels = [ProjectFeature::DISABLED, ProjectFeature::PRIVATE, ProjectFeature::ENABLED] + + levels.each do |level| + it "creates reference when the feature is #{level}" do + project.project_feature.update(issues_access_level: level) + + visible_nodes = subject.nodes_visible_to_user(user, [link]) + + expect(visible_nodes).to include(link) + end + end end end |