diff options
author | Sean McGivern <sean@mcgivern.me.uk> | 2017-12-08 14:20:31 +0000 |
---|---|---|
committer | Sean McGivern <sean@mcgivern.me.uk> | 2017-12-08 14:20:31 +0000 |
commit | 1fb49ccd7bb37d5d6bde12397f32e1c04fc009ba (patch) | |
tree | c42df47ade7fad6529f59398d5e1275619994fd9 /spec | |
parent | 103269b9a6d92ff3d4d0f3b69e4653e3f0ef7744 (diff) | |
parent | 3e83d9f73a2dbec010026dbcd24effe89d4dc16f (diff) | |
download | gitlab-ce-1fb49ccd7bb37d5d6bde12397f32e1c04fc009ba.tar.gz |
Merge branch 'jprovazn-ignore-anchors' into 'master'
Use prefix for TableOfContents filter hrefs
Closes #38473
See merge request gitlab-org/gitlab-ce!15806
Diffstat (limited to 'spec')
-rw-r--r-- | spec/lib/banzai/filter/table_of_contents_filter_spec.rb | 7 | ||||
-rw-r--r-- | spec/lib/gitlab/reference_extractor_spec.rb | 9 |
2 files changed, 16 insertions, 0 deletions
diff --git a/spec/lib/banzai/filter/table_of_contents_filter_spec.rb b/spec/lib/banzai/filter/table_of_contents_filter_spec.rb index 85eddde732e..0cfef4ff5bf 100644 --- a/spec/lib/banzai/filter/table_of_contents_filter_spec.rb +++ b/spec/lib/banzai/filter/table_of_contents_filter_spec.rb @@ -65,6 +65,13 @@ describe Banzai::Filter::TableOfContentsFilter do expect(doc.css('h2 a').first.attr('href')).to eq '#one-1' end + it 'prepends a prefix to digits-only ids' do + doc = filter(header(1, "123") + header(2, "1.0")) + + expect(doc.css('h1 a').first.attr('href')).to eq '#anchor-123' + expect(doc.css('h2 a').first.attr('href')).to eq '#anchor-10' + end + it 'supports Unicode' do doc = filter(header(1, '한글')) expect(doc.css('h1 a').first.attr('id')).to eq 'user-content-한글' diff --git a/spec/lib/gitlab/reference_extractor_spec.rb b/spec/lib/gitlab/reference_extractor_spec.rb index ef874368077..8ec3f55e6de 100644 --- a/spec/lib/gitlab/reference_extractor_spec.rb +++ b/spec/lib/gitlab/reference_extractor_spec.rb @@ -115,6 +115,15 @@ describe Gitlab::ReferenceExtractor do end end + it 'does not include anchors from table of contents in issue references' do + issue1 = create(:issue, project: project) + issue2 = create(:issue, project: project) + + subject.analyze("not real issue <h4>#{issue1.iid}</h4>, real issue #{issue2.to_reference}") + + expect(subject.issues).to match_array([issue2]) + end + it 'accesses valid issue objects' do @i0 = create(:issue, project: project) @i1 = create(:issue, project: project) |