Hide issues and MRs in labels list if disabledsophie-h/gitlab-ce-patch-15

Signed-off-by: Rémy Coutable <remy@rymai.me>

3 files changed, 153 insertions, 0 deletions

diff --git a/spec/features/groups/labels/user_sees_links_to_issuables.rb b/spec/features/groups/labels/user_sees_links_to_issuables.rb
new file mode 100644
index 00000000000..5d6290d2109
--- /dev/null
+++ b/spec/features/groups/labels/user_sees_links_to_issuables.rb
@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+feature 'Groups > Labels > User sees links to issuables' do
+  set(:group) { create(:group, :public) }
+
+  before do
+    create(:group_label, group: group, title: 'bug')
+    visit group_labels_path(group)
+  end
+
+  scenario 'shows links to MRs and issues' do
+    expect(page).to have_link('view merge requests')
+    expect(page).to have_link('view open issues')
+  end
+end
diff --git a/spec/features/projects/labels/user_sees_links_to_issuables.rb b/spec/features/projects/labels/user_sees_links_to_issuables.rb
new file mode 100644
index 00000000000..aa56fd7f74e
--- /dev/null
+++ b/spec/features/projects/labels/user_sees_links_to_issuables.rb
@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+feature 'Projects > Labels > User sees links to issuables' do
+  set(:user) { create(:user) }
+
+  before do
+    label # creates the label
+    project.add_developer(user)
+    sign_in user
+    visit project_labels_path(project)
+  end
+
+  context 'with a project label' do
+    let(:label) { create(:label, project: project, title: 'bug') }
+
+    context 'when merge requests and issues are enabled for the project' do
+      let(:project) { create(:project, :public) }
+
+      scenario 'shows links to MRs and issues' do
+        expect(page).to have_link('view merge requests')
+        expect(page).to have_link('view open issues')
+      end
+    end
+
+    context 'when issues are disabled for the project' do
+      let(:project) { create(:project, :public, issues_access_level: ProjectFeature::DISABLED) }
+
+      scenario 'shows links to MRs but not to issues' do
+        expect(page).to have_link('view merge requests')
+        expect(page).not_to have_link('view open issues')
+      end
+    end
+
+    context 'when merge requests are disabled for the project' do
+      let(:project) { create(:project, :public, merge_requests_access_level: ProjectFeature::DISABLED) }
+
+      scenario 'shows links to issues but not to MRs' do
+        expect(page).not_to have_link('view merge requests')
+        expect(page).to have_link('view open issues')
+      end
+    end
+  end
+
+  context 'with a group label' do
+    set(:group) { create(:group) }
+    let(:label) { create(:group_label, group: group, title: 'bug') }
+
+    context 'when merge requests and issues are enabled for the project' do
+      let(:project) { create(:project, :public, namespace: group) }
+
+      scenario 'shows links to MRs and issues' do
+        expect(page).to have_link('view merge requests')
+        expect(page).to have_link('view open issues')
+      end
+    end
+
+    context 'when issues are disabled for the project' do
+      let(:project) { create(:project, :public, namespace: group, issues_access_level: ProjectFeature::DISABLED) }
+
+      scenario 'shows links to MRs and issues' do
+        expect(page).to have_link('view merge requests')
+        expect(page).to have_link('view open issues')
+      end
+    end
+
+    context 'when merge requests are disabled for the project' do
+      let(:project) { create(:project, :public, namespace: group, merge_requests_access_level: ProjectFeature::DISABLED) }
+
+      scenario 'shows links to MRs and issues' do
+        expect(page).to have_link('view merge requests')
+        expect(page).to have_link('view open issues')
+      end
+    end
+  end
+end
diff --git a/spec/helpers/labels_helper_spec.rb b/spec/helpers/labels_helper_spec.rb
index 4ac4302adfd..0286d36952c 100644
--- a/spec/helpers/labels_helper_spec.rb
+++ b/spec/helpers/labels_helper_spec.rb
@@ -1,6 +1,69 @@
 require 'spec_helper'
 
 describe LabelsHelper do
+  describe '#show_label_issuables_link?' do
+    shared_examples 'a valid response to show_label_issuables_link?' do |issuables_type, when_enabled = true, when_disabled = false|
+      let(:context_project) { project }
+
+      context "when asking for a #{issuables_type} link" do
+        subject { show_label_issuables_link?(label, issuables_type, project: context_project) }
+
+        context "when #{issuables_type} are enabled for the project" do
+          let(:project) { create(:project, "#{issuables_type}_access_level": ProjectFeature::ENABLED) }
+
+          it { is_expected.to be(when_enabled) }
+        end
+
+        context "when #{issuables_type} are disabled for the project" do
+          let(:project) { create(:project, :public, "#{issuables_type}_access_level": ProjectFeature::DISABLED) }
+
+          it { is_expected.to be(when_disabled) }
+        end
+      end
+    end
+
+    context 'with a project label' do
+      let(:label) { create(:label, project: project, title: 'bug') }
+
+      context 'when asking for an issue link' do
+        it_behaves_like 'a valid response to show_label_issuables_link?', :issues
+      end
+
+      context 'when asking for a merge requests link' do
+        it_behaves_like 'a valid response to show_label_issuables_link?', :merge_requests
+      end
+    end
+
+    context 'with a group label' do
+      set(:group) { create(:group) }
+      let(:label) { create(:group_label, group: group, title: 'bug') }
+
+      context 'when asking for an issue link' do
+        context 'in the context of a project' do
+          it_behaves_like 'a valid response to show_label_issuables_link?', :issues, true, true
+        end
+
+        context 'in the context of a group' do
+          let(:context_project) { nil }
+
+          it_behaves_like 'a valid response to show_label_issuables_link?', :issues, true, true
+        end
+      end
+
+      context 'when asking for a merge requests link' do
+        context 'in the context of a project' do
+          it_behaves_like 'a valid response to show_label_issuables_link?', :merge_requests, true, true
+        end
+
+        context 'in the context of a group' do
+          let(:context_project) { nil }
+
+          it_behaves_like 'a valid response to show_label_issuables_link?', :merge_requests, true, true
+        end
+      end
+    end
+  end
+
   describe 'link_to_label' do
     let(:project) { create(:project) }
     let(:label) { create(:label, project: project) }