Renames Cluster#managed? to provided_by_user?

This will allow to user the term managed? on
https://gitlab.com/gitlab-org/gitlab-ce/issues/56557. Managed? will be
used to distinct clusters that are automatically managed by GitLab

4 files changed, 113 insertions, 1 deletions

diff --git a/spec/features/clusters/cluster_detail_page_spec.rb b/spec/features/clusters/cluster_detail_page_spec.rb
index b9fc52d0dce..d2e46d15730 100644
--- a/spec/features/clusters/cluster_detail_page_spec.rb
+++ b/spec/features/clusters/cluster_detail_page_spec.rb
@@ -53,12 +53,80 @@ describe 'Clusterable > Show page' do
     end
   end
 
+  shared_examples 'editing a GCP cluster' do
+    before do
+      clusterable.add_maintainer(current_user)
+      visit cluster_path
+    end
+
+    it 'is not able to edit the name, API url, CA certificate nor token' do
+      within('#js-cluster-details') do
+        cluster_name_field = find('.cluster-name')
+        api_url_field = find('#cluster_platform_kubernetes_attributes_api_url')
+        ca_certificate_field = find('#cluster_platform_kubernetes_attributes_ca_cert')
+        token_field = find('#cluster_platform_kubernetes_attributes_token')
+
+        expect(cluster_name_field).to be_readonly
+        expect(api_url_field).to be_readonly
+        expect(ca_certificate_field).to be_readonly
+        expect(token_field).to be_readonly
+      end
+    end
+
+    it 'displays GKE information' do
+      within('#advanced-settings-section') do
+        expect(page).to have_content('Google Kubernetes Engine')
+        expect(page).to have_content('Manage your Kubernetes cluster by visiting')
+      end
+    end
+  end
+
+  shared_examples 'editing a user-provided cluster' do
+    before do
+      clusterable.add_maintainer(current_user)
+      visit cluster_path
+    end
+
+    it 'is able to edit the name, API url, CA certificate and token' do
+      within('#js-cluster-details') do
+        cluster_name_field = find('#cluster_name')
+        api_url_field = find('#cluster_platform_kubernetes_attributes_api_url')
+        ca_certificate_field = find('#cluster_platform_kubernetes_attributes_ca_cert')
+        token_field = find('#cluster_platform_kubernetes_attributes_token')
+
+        expect(cluster_name_field).not_to be_readonly
+        expect(api_url_field).not_to be_readonly
+        expect(ca_certificate_field).not_to be_readonly
+        expect(token_field).not_to be_readonly
+      end
+    end
+
+    it 'does not display GKE information' do
+      within('#advanced-settings-section') do
+        expect(page).not_to have_content('Google Kubernetes Engine')
+        expect(page).not_to have_content('Manage your Kubernetes cluster by visiting')
+      end
+    end
+  end
+
   context 'when clusterable is a project' do
     it_behaves_like 'editing domain' do
       let(:clusterable) { create(:project) }
       let(:cluster) { create(:cluster, :provided_by_gcp, :project, projects: [clusterable]) }
       let(:cluster_path) { project_cluster_path(clusterable, cluster) }
     end
+
+    it_behaves_like 'editing a GCP cluster' do
+      let(:clusterable) { create(:project) }
+      let(:cluster) { create(:cluster, :provided_by_gcp, :project, projects: [clusterable]) }
+      let(:cluster_path) { project_cluster_path(clusterable, cluster) }
+    end
+
+    it_behaves_like 'editing a user-provided cluster' do
+      let(:clusterable) { create(:project) }
+      let(:cluster) { create(:cluster, :provided_by_user, :project, projects: [clusterable]) }
+      let(:cluster_path) { project_cluster_path(clusterable, cluster) }
+    end
   end
 
   context 'when clusterable is a group' do
@@ -67,5 +135,17 @@ describe 'Clusterable > Show page' do
       let(:cluster) { create(:cluster, :provided_by_gcp, :group, groups: [clusterable]) }
       let(:cluster_path) { group_cluster_path(clusterable, cluster) }
     end
+
+    it_behaves_like 'editing a GCP cluster' do
+      let(:clusterable) { create(:group) }
+      let(:cluster) { create(:cluster, :provided_by_gcp, :group, groups: [clusterable]) }
+      let(:cluster_path) { group_cluster_path(clusterable, cluster) }
+    end
+
+    it_behaves_like 'editing a user-provided cluster' do
+      let(:clusterable) { create(:group) }
+      let(:cluster) { create(:cluster, :provided_by_user, :group, groups: [clusterable]) }
+      let(:cluster_path) { group_cluster_path(clusterable, cluster) }
+    end
   end
 end
diff --git a/spec/models/clusters/cluster_spec.rb b/spec/models/clusters/cluster_spec.rb
index acbcdc7d170..fabd2806d9a 100644
--- a/spec/models/clusters/cluster_spec.rb
+++ b/spec/models/clusters/cluster_spec.rb
@@ -620,4 +620,20 @@ describe Clusters::Cluster do
       end
     end
   end
+
+  describe '#provided_by_user?' do
+    subject { cluster.provided_by_user? }
+
+    context 'with a GCP provider' do
+      let(:cluster) { create(:cluster, :provided_by_gcp) }
+
+      it { is_expected.to be_falsy }
+    end
+
+    context 'with an user provider' do
+      let(:cluster) { create(:cluster, :provided_by_user) }
+
+      it { is_expected.to be_truthy }
+    end
+  end
 end
diff --git a/spec/models/clusters/platforms/kubernetes_spec.rb b/spec/models/clusters/platforms/kubernetes_spec.rb
index af65530e663..a79b436c22a 100644
--- a/spec/models/clusters/platforms/kubernetes_spec.rb
+++ b/spec/models/clusters/platforms/kubernetes_spec.rb
@@ -15,7 +15,7 @@ describe Clusters::Platforms::Kubernetes, :use_clean_rails_memory_store_caching
 
   it { is_expected.to delegate_method(:project).to(:cluster) }
   it { is_expected.to delegate_method(:enabled?).to(:cluster) }
-  it { is_expected.to delegate_method(:managed?).to(:cluster) }
+  it { is_expected.to delegate_method(:provided_by_user?).to(:cluster) }
   it { is_expected.to delegate_method(:kubernetes_namespace).to(:cluster) }
 
   it_behaves_like 'having unique enum values'
diff --git a/spec/presenters/clusters/cluster_presenter_spec.rb b/spec/presenters/clusters/cluster_presenter_spec.rb
index 754ba0a594c..a9d786bc872 100644
--- a/spec/presenters/clusters/cluster_presenter_spec.rb
+++ b/spec/presenters/clusters/cluster_presenter_spec.rb
@@ -228,4 +228,20 @@ describe Clusters::ClusterPresenter do
       it { is_expected.to eq(group_cluster_path(group, cluster)) }
     end
   end
+
+  describe '#read_only_kubernetes_platform_fields?' do
+    subject { described_class.new(cluster).read_only_kubernetes_platform_fields? }
+
+    context 'with a user-provided cluster' do
+      let(:cluster) { build_stubbed(:cluster, :provided_by_user) }
+
+      it { is_expected.to be_falsy }
+    end
+
+    context 'with a GCP-provided cluster' do
+      let(:cluster) { build_stubbed(:cluster, :provided_by_gcp) }
+
+      it { is_expected.to be_truthy }
+    end
+  end
 end