Merge branch '30469-convdev-index' into 'master'

ConvDev Index

Closes #30469

See merge request !11377

5 files changed, 214 insertions, 14 deletions

diff --git a/spec/factories/conversational_development_index_metrics.rb b/spec/factories/conversational_development_index_metrics.rb
new file mode 100644
index 00000000000..a5412629195
--- /dev/null
+++ b/spec/factories/conversational_development_index_metrics.rb
@@ -0,0 +1,33 @@
+FactoryGirl.define do
+  factory :conversational_development_index_metric, class: ConversationalDevelopmentIndex::Metric do
+    leader_issues 9.256
+    instance_issues 1.234
+
+    leader_notes 30.33333
+    instance_notes 28.123
+
+    leader_milestones 16.2456
+    instance_milestones 1.234
+
+    leader_boards 5.2123
+    instance_boards 3.254
+
+    leader_merge_requests 1.2
+    instance_merge_requests 0.6
+
+    leader_ci_pipelines 12.1234
+    instance_ci_pipelines 2.344
+
+    leader_environments 3.3333
+    instance_environments 2.2222
+
+    leader_deployments 1.200
+    instance_deployments 0.771
+
+    leader_projects_prometheus_active 0.111
+    instance_projects_prometheus_active 0.109
+
+    leader_service_desk_issues 15.891
+    instance_service_desk_issues 13.345
+  end
+end
diff --git a/spec/features/admin/admin_conversational_development_index_spec.rb b/spec/features/admin/admin_conversational_development_index_spec.rb
new file mode 100644
index 00000000000..739ab907a29
--- /dev/null
+++ b/spec/features/admin/admin_conversational_development_index_spec.rb
@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe 'Admin Conversational Development Index' do
+  before do
+    login_as :admin
+  end
+
+  context 'when usage ping is disabled' do
+    it 'shows empty state' do
+      stub_application_setting(usage_ping_enabled: false)
+
+      visit admin_conversational_development_index_path
+
+      expect(page).to have_content('Usage ping is not enabled')
+    end
+  end
+
+  context 'when there is no data to display' do
+    it 'shows empty state' do
+      stub_application_setting(usage_ping_enabled: true)
+
+      visit admin_conversational_development_index_path
+
+      expect(page).to have_content('Data is still calculating')
+    end
+  end
+
+  context 'when there is data to display' do
+    it 'shows numbers for each metric' do
+      stub_application_setting(usage_ping_enabled: true)
+      create(:conversational_development_index_metric)
+
+      visit admin_conversational_development_index_path
+
+      expect(page).to have_content(
+        'Issues created per active user 1.2 You 9.3 Lead 13.3%'
+      )
+    end
+  end
+end
diff --git a/spec/presenters/conversational_development_index/metric_presenter_spec.rb b/spec/presenters/conversational_development_index/metric_presenter_spec.rb
new file mode 100644
index 00000000000..1e015c71f5b
--- /dev/null
+++ b/spec/presenters/conversational_development_index/metric_presenter_spec.rb
@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe ConversationalDevelopmentIndex::MetricPresenter do
+  subject { described_class.new(metric) }
+  let(:metric) { build(:conversational_development_index_metric) }
+
+  describe '#cards' do
+    it 'includes instance score, leader score and percentage score' do
+      issues_card = subject.cards.first
+
+      expect(issues_card.instance_score).to eq 1.234
+      expect(issues_card.leader_score).to eq 9.256
+      expect(issues_card.percentage_score).to be_within(0.1).of(13.3)
+    end
+  end
+
+  describe '#idea_to_production_steps' do
+    it 'returns percentage score when it depends on a single feature' do
+      code_step = subject.idea_to_production_steps.fourth
+
+      expect(code_step.percentage_score).to be_within(0.1).of(50.0)
+    end
+
+    it 'returns percentage score when it depends on two features' do
+      issue_step = subject.idea_to_production_steps.second
+
+      expect(issue_step.percentage_score).to be_within(0.1).of(53.0)
+    end
+  end
+
+  describe '#average_percentage_score' do
+    it 'calculates an average value across all the features' do
+      expect(subject.average_percentage_score).to be_within(0.1).of(55.8)
+    end
+  end
+end
diff --git a/spec/services/submit_usage_ping_service_spec.rb b/spec/services/submit_usage_ping_service_spec.rb
new file mode 100644
index 00000000000..63a1e78f274
--- /dev/null
+++ b/spec/services/submit_usage_ping_service_spec.rb
@@ -0,0 +1,101 @@
+require 'spec_helper'
+
+describe SubmitUsagePingService do
+  context 'when usage ping is disabled' do
+    before do
+      stub_application_setting(usage_ping_enabled: false)
+    end
+
+    it 'does not run' do
+      expect(HTTParty).not_to receive(:post)
+
+      result = subject.execute
+
+      expect(result).to eq false
+    end
+  end
+
+  context 'when usage ping is enabled' do
+    before do
+      stub_application_setting(usage_ping_enabled: true)
+    end
+
+    it 'sends a POST request' do
+      response = stub_response(without_conv_index_params)
+
+      subject.execute
+
+      expect(response).to have_been_requested
+    end
+
+    it 'refreshes usage data statistics before submitting' do
+      stub_response(without_conv_index_params)
+
+      expect(Gitlab::UsageData).to receive(:to_json)
+        .with(force_refresh: true)
+        .and_call_original
+
+      subject.execute
+    end
+
+    it 'saves conversational development index data from the response' do
+      stub_response(with_conv_index_params)
+
+      expect { subject.execute }
+        .to change { ConversationalDevelopmentIndex::Metric.count }
+        .by(1)
+
+      expect(ConversationalDevelopmentIndex::Metric.last.leader_issues).to eq 10.2
+    end
+  end
+
+  def without_conv_index_params
+    {
+      conv_index: {}
+    }
+  end
+
+  def with_conv_index_params
+    {
+      conv_index: {
+        leader_issues: 10.2,
+        instance_issues: 3.2,
+
+        leader_notes: 25.3,
+        instance_notes: 23.2,
+
+        leader_milestones: 16.2,
+        instance_milestones: 5.5,
+
+        leader_boards: 5.2,
+        instance_boards: 3.2,
+
+        leader_merge_requests: 5.2,
+        instance_merge_requests: 3.2,
+
+        leader_ci_pipelines: 25.1,
+        instance_ci_pipelines: 21.3,
+
+        leader_environments: 3.3,
+        instance_environments: 2.2,
+
+        leader_deployments: 41.3,
+        instance_deployments: 15.2,
+
+        leader_projects_prometheus_active: 0.31,
+        instance_projects_prometheus_active: 0.30,
+
+        leader_service_desk_issues: 15.8,
+        instance_service_desk_issues: 15.1
+      }
+    }
+  end
+
+  def stub_response(body)
+    stub_request(:post, 'https://version.gitlab.com/usage_data').
+      to_return(
+        headers: { 'Content-Type' => 'application/json' },
+        body: body.to_json
+      )
+  end
+end
diff --git a/spec/workers/gitlab_usage_ping_worker_spec.rb b/spec/workers/gitlab_usage_ping_worker_spec.rb
index 26241044533..49b4e04dc7c 100644
--- a/spec/workers/gitlab_usage_ping_worker_spec.rb
+++ b/spec/workers/gitlab_usage_ping_worker_spec.rb
@@ -3,21 +3,11 @@ require 'spec_helper'
 describe GitlabUsagePingWorker do
   subject { described_class.new }
 
-  it "sends POST request" do
-    stub_application_setting(usage_ping_enabled: true)
+  it 'delegates to SubmitUsagePingService' do
+    allow(subject).to receive(:try_obtain_lease).and_return(true)
 
-    stub_request(:post, "https://version.gitlab.com/usage_data").
-        to_return(status: 200, body: '', headers: {})
-    expect(Gitlab::UsageData).to receive(:to_json).with({ force_refresh: true }).and_call_original
-    expect(subject).to receive(:try_obtain_lease).and_return(true)
+    expect_any_instance_of(SubmitUsagePingService).to receive(:execute)
 
-    expect(subject.perform.response.code.to_i).to eq(200)
-  end
-
-  it "does not run if usage ping is disabled" do
-    stub_application_setting(usage_ping_enabled: false)
-
-    expect(subject).not_to receive(:try_obtain_lease)
-    expect(subject).not_to receive(:perform)
+    subject.perform
   end
 end