diff options
author | Mark Lapierre <mlapierre@gitlab.com> | 2019-07-12 05:18:42 +0000 |
---|---|---|
committer | Mark Lapierre <mlapierre@gitlab.com> | 2019-07-12 05:18:42 +0000 |
commit | b51ec1fb01922fe8b81ae3098a1578fb1622fabc (patch) | |
tree | 01acbe2a9325e7e5d7a64e385906f29f8dc576c0 /spec | |
parent | ecffca5d92353d55aaf8f984737fa617782310e0 (diff) | |
parent | 3281e6db23d8f1ea6757af6eb71e87ed7a93c130 (diff) | |
download | gitlab-ce-b51ec1fb01922fe8b81ae3098a1578fb1622fabc.tar.gz |
Merge branch 'qa-dd-data-qa-selector-replacement' into 'master'
Introduce data-qa-selector to supplant .qa-class
See merge request gitlab-org/gitlab-ce!28906
Diffstat (limited to 'spec')
-rw-r--r-- | spec/rubocop/cop/qa/element_with_pattern_spec.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/spec/rubocop/cop/qa/element_with_pattern_spec.rb b/spec/rubocop/cop/qa/element_with_pattern_spec.rb index ef20d9a1f26..fee390caa9f 100644 --- a/spec/rubocop/cop/qa/element_with_pattern_spec.rb +++ b/spec/rubocop/cop/qa/element_with_pattern_spec.rb @@ -23,9 +23,9 @@ describe RuboCop::Cop::QA::ElementWithPattern do expect_offense(<<-RUBY) view 'app/views/shared/groups/_search_form.html.haml' do element :groups_filter, 'search_field_tag :filter' - ^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use a pattern for element, create a corresponding `qa-groups-filter` instead. + ^^^^^^^^^^^^^^^^^^^^^^^^^^ Don't use a pattern for element, create a corresponding `data-qa-selector=groups_filter` instead. element :groups_filter_placeholder, /Search by name/ - ^^^^^^^^^^^^^^ Don't use a pattern for element, create a corresponding `qa-groups-filter-placeholder` instead. + ^^^^^^^^^^^^^^ Don't use a pattern for element, create a corresponding `data-qa-selector=groups_filter_placeholder` instead. end RUBY end |