summaryrefslogtreecommitdiff
path: root/spec
diff options
context:
space:
mode:
authorDouwe Maan <douwe@gitlab.com>2017-06-02 22:16:54 +0000
committerDouwe Maan <douwe@gitlab.com>2017-06-02 22:16:54 +0000
commit70b927a55ca62f1219464182660877bcdefd55b0 (patch)
tree23aa15039675ed3c9e536a739b74f6c2ed2e53ff /spec
parent8f7fc44b63f728d4de9c2e57a1452c53fa02a642 (diff)
parentc2516115e391360055f733d40af8aff2af52196b (diff)
downloadgitlab-ce-70b927a55ca62f1219464182660877bcdefd55b0.tar.gz
Merge branch 'projects-api-import-status' into 'master'
Expose import_status in Projects API Closes #19646 See merge request !11851
Diffstat (limited to 'spec')
-rw-r--r--spec/requests/api/projects_spec.rb20
1 files changed, 20 insertions, 0 deletions
diff --git a/spec/requests/api/projects_spec.rb b/spec/requests/api/projects_spec.rb
index 40bfc0c636b..5c13cea69fb 100644
--- a/spec/requests/api/projects_spec.rb
+++ b/spec/requests/api/projects_spec.rb
@@ -635,6 +635,8 @@ describe API::Projects do
expect(json_response['shared_runners_enabled']).to be_present
expect(json_response['creator_id']).to be_present
expect(json_response['namespace']).to be_present
+ expect(json_response['import_status']).to be_present
+ expect(json_response).to include("import_error")
expect(json_response['avatar_url']).to be_nil
expect(json_response['star_count']).to be_present
expect(json_response['forks_count']).to be_present
@@ -702,6 +704,20 @@ describe API::Projects do
expect(json_response).to include 'statistics'
end
+ it "includes import_error if user can admin project" do
+ get api("/projects/#{project.id}", user)
+
+ expect(response).to have_http_status(200)
+ expect(json_response).to include("import_error")
+ end
+
+ it "does not include import_error if user cannot admin project" do
+ get api("/projects/#{project.id}", user3)
+
+ expect(response).to have_http_status(200)
+ expect(json_response).not_to include("import_error")
+ end
+
describe 'permissions' do
context 'all projects' do
before { project.team << [user, :master] }
@@ -1464,6 +1480,8 @@ describe API::Projects do
expect(json_response['owner']['id']).to eq(user2.id)
expect(json_response['namespace']['id']).to eq(user2.namespace.id)
expect(json_response['forked_from_project']['id']).to eq(project.id)
+ expect(json_response['import_status']).to eq('started')
+ expect(json_response).to include("import_error")
end
it 'forks if user is admin' do
@@ -1475,6 +1493,8 @@ describe API::Projects do
expect(json_response['owner']['id']).to eq(admin.id)
expect(json_response['namespace']['id']).to eq(admin.namespace.id)
expect(json_response['forked_from_project']['id']).to eq(project.id)
+ expect(json_response['import_status']).to eq('started')
+ expect(json_response).to include("import_error")
end
it 'fails on missing project access for the project to fork' do